Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 FS#8986 : File deletion target changes with trackchange - therefore 'wrong' file deleted

Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bascule - 2008-05-12
Last edited by pondlife - 2008-05-13

FS#8986 - File deletion target changes with trackchange - therefore 'wrong' file deleted

This bug occurs when playing back a file and choosing to delete it from the WPS context menu while it is still playing.

If a trackchange occurs between choosing a file for deletion and actually pressing the 'Yes' option, the *new* currently playing file is deleted, rather than the one originally selected for deletion.

For example using the following playlist:
a.mp3
b.mp3
c.mp3
d.mp3

If b.mp3 is playing and a few seconds before the track ends, the user selects [context menu] > Delete

The screeen displays:

Delete?
b.mp3

SELECT = Yes
Any Other = No

Wait until c.mp3 commences playback, then press SELECT

The screeen displays:

Deleted
c.mp3

http://forums.rockbox.org/index.php?topic=16785.0 refers.

Closed by  pondlife
2008-05-13 13:51
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Hopefully r17494 should sort this out.

I thought we didnt allow the delete option in the wps context menu because nasty things happen if you try deleting a file while its not fully buffered, and this… should the option be removed?

Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

Personally I find it a very useful function whilst listening to podcasts etc. and I would not like to see it removed, especially as it was committed by a certain jdgordon ;-) http://www.rockbox.org/tracker/task/7437

However, unless the method by which the code determines the target file cannot be fixed, then maybe it should, as it is certainly not the behaviour that a user would expect and it will occur at exactly the time when a user is most likely to use the functionality i.e., at the end of a track.

haha, damn split personality :p
ok, a patch to fix the problem would be more than welcome….

Does this help?

Oh yes!

Thanks Steve, that patch works perfectly for me. Is it able to be commited?

My untrained eye doesn't see anything in the code or the functionality that could upset anyone…

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing