FS#8989 - start of rec trigger settings -> viewport

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 13 May 2008, 10:35 GMT
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 28 May 2008, 11:02 GMT
Task Type Patches
Category Recording
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


the plan for this patch was to change the rec trigger settings screen to not use inline settings... ideally to show the menu and optoins in a VP at the top of the screen and have a 2nd vp for the peak meters at the bottom...
I unfortunatly finished the top bit before realsing the peakmeters wouldnt be updated :(

so im putting this here in the hope someone comes up woth a solution
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 28 May 2008, 11:02 GMT
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Tuesday, 13 May 2008, 15:15 GMT
so, this isnt as good as I was planning, but it still saves about 1.3k on the rec build...

2 line settings, the top line has an icon so it should be workable.

NOTE: this version doesnt talk, need to put that back in...
Comment by Jonathan Gordon (jdgordon) - Thursday, 15 May 2008, 07:24 GMT
new version.. should actually work now and buttons are hopefully better, attached is the full zip for h120
Comment by Jonathan Gordon (jdgordon) - Wednesday, 21 May 2008, 07:54 GMT
new version.. talks goodly.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 21 May 2008, 14:07 GMT
hoipefully final version... commiting in a day or two unless anyone comments...
If the only negative against this patch is the 2 line settings then IMO thats not a big enough deal to hold this out. major issues fixed here is no need to keep setting values in sync in multiple places, should give a big green delta, no more abusing a setting, etc
Comment by Marianne Arnold (pixelma) - Wednesday, 21 May 2008, 22:24 GMT
The last patch does not compile for my OndioFM (with or without the "changes" for the backlight mod). Building fails with

/1_builds/ondiofm/apps/menus/recording_menu.o: In function `_rectrigger':
recording_menu.c:(.text+0x538): undefined reference to `_option_select_next_val'

However it builds for M5 and c200. Tried to play around with it and it seems to do something on M5 (and the trigger indicator showed correctly different behaviour when changing the thresholds for example but I didn't have enough experience with triggered recording and some handy recording equipment to test more.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 21 May 2008, 22:38 GMT
ondio is missing quickscreen which currently that function isnt compiled for, that'll be fixed