• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2008-05-19
Last edited by Buschel - 2008-05-22

FS#9015 - rework of musepack seek buffering

The seek buffer implementation of musepack is quite buggy (as discussed in irc). This is a major rework of the seek buffer. The patch does not remove the old code – it is commented.

Use constant buffer size of 8192 words. This gives a precision of 1 frame on a 3.5 min file and 0.5 sec on a 1 hour file. The precision of the seeking is adapted to the file’s duration.

Test and review needed.

Closed by  Buschel
2008-05-22 12:34
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Final fix committed with r17606

Tests with mpc files with durations of 64, 68 and 72 minutes show that the seeking now works with such files.
One issue is open: Sometimes seeking backwards lead to skipping back one file – this bug also shows up with the current svn.

This version was committed with r17604. I keep this flyspray entry open, if there are additional update/fixes neccessary.


Available keyboard shortcuts


Task Details

Task Editing