FS#9015 - rework of musepack seek buffering

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Monday, 19 May 2008, 21:45 GMT
Last edited by Andree Buschmann (Buschel) - Thursday, 22 May 2008, 12:34 GMT
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The seek buffer implementation of musepack is quite buggy (as discussed in irc). This is a major rework of the seek buffer. The patch does not remove the old code -- it is commented.

Use constant buffer size of 8192 words. This gives a precision of 1 frame on a 3.5 min file and 0.5 sec on a 1 hour file. The precision of the seeking is adapted to the file's duration.

Test and review needed.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Thursday, 22 May 2008, 12:34 GMT
Reason for closing:  Accepted
Additional comments about closing:  Final fix committed with r17606
Comment by Andree Buschmann (Buschel) - Wednesday, 21 May 2008, 20:21 GMT
Tests with mpc files with durations of 64, 68 and 72 minutes show that the seeking now works with such files.
One issue is open: Sometimes seeking backwards lead to skipping back one file -- this bug also shows up with the current svn.
Comment by Andree Buschmann (Buschel) - Thursday, 22 May 2008, 09:59 GMT
This version was committed with r17604. I keep this flyspray entry open, if there are additional update/fixes neccessary.