FS#9030 - Mod player data abort

Attached to Project: Rockbox
Opened by Mark (Xebozone) - Friday, 23 May 2008, 13:54 GMT
Last edited by Marc Guay (Marc_Guay) - Friday, 11 July 2008, 00:22 GMT
Task Type Bugs
Category Codecs
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I get a Data abort at 4000D8C0 (0) every time i try to play a mod file (tested with the mods from Unreal Gold) on my iPod 5G 30gb
This task depends upon

Closed by  Marc Guay (Marc_Guay)
Friday, 11 July 2008, 00:22 GMT
Reason for closing:  Invalid
Additional comments about closing:  OP was using an S3M file, not a MOD. Tested pitch shifting with a proper MOD file and had no problems.
Comment by Nils Wallménius (nls) - Friday, 23 May 2008, 15:48 GMT
from the map it seems like the data abort happens in synthrender()

And from looking at it line 1186 seems suspicious, an array of signed char is casted to signed short, this can data abort if the access is not short aligned.

Also i don't have any mod files at all so if you could post or link to one which triggers the bug it would help.
Comment by Thom Johansen (preglow) - Friday, 23 May 2008, 18:13 GMT
Doesn't Unreal base itself on the .s3m format? The MOD codec only plays .mod. I'm not 100% sure of this, and the codec should of course not crash anyway if this was so.
Comment by Mark (Xebozone) - Saturday, 24 May 2008, 03:49 GMT
oh might do...
but it's a tracker format anyways
Comment by Mark (Xebozone) - Saturday, 24 May 2008, 03:51 GMT
I assumed unreal music was mod becuase it plays on my PC's mod player
Comment by Mark (Xebozone) - Saturday, 24 May 2008, 04:46 GMT
Correction, UMX files would not play on winamp (my mod player)
I converted them to a playable format (S3m) with the unreal editor.
They play on Winamp now.
A data abort doesn't seem to happen, but the files do not play properly (this, i'm sure is expected).
But boosting the pitch will up to 200% will cause a data abort.
This FS ca probably be closed now due to my ignorance on tracker formats :P
Comment by Thom Johansen (preglow) - Saturday, 24 May 2008, 17:59 GMT
Does a data abort happen or doesn't it? And what do you mean by "not play properly"? You need to be more specific about what the actual bug is.
Comment by Mark (Xebozone) - Sunday, 25 May 2008, 03:43 GMT
it doesn't seem to happen after the convesion, until i speed it up (via the pitch option)
But it doesn't play properly anyways because it's S3M format, not MOD
Comment by Thom Johansen (preglow) - Sunday, 25 May 2008, 14:51 GMT
Ok, so the MOD player crashes on pitch up? Can anyone else verify if this always happens?
Comment by Mark (Xebozone) - Sunday, 25 May 2008, 14:53 GMT
you misunderstand me!
please take into account that i wasn't even playing a MOD file!
Comment by Mark (Xebozone) - Thursday, 05 June 2008, 10:16 GMT
This FS probably should be closed, as I mistook a s3m for a mod.
I haven't yet tried to play MOD, but if i did...this error may not occur.

Someone should test it, however just in case (and to read the first comment)