FS#909 - Disk poweroff settings not handled correctly

Attached to Project: Rockbox
Opened by Mike Holden (mikeholden) - Wednesday, 12 February 2003, 08:46 GMT
Last edited by Björn Stenberg (zagor) - Tuesday, 15 April 2003, 22:45 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Problem is on both recorder models. The config-*recorder.h files
define HAVE_ATA_POWER_OFF, but settings.c checks whether
ATA_POWER_OFF is defined - this will never be set. This
means that disk poweroff is ALWAYS enabled, regardless of
what the user sets in the settings screen.

The consequence of this on the FM Recorder is that the backlight
gets disabled. Fixing this will mean that the backlight for FM users
will work correctly if they set Disk Poweroff to No.
This task depends upon

Closed by  Björn Stenberg (zagor)
Tuesday, 15 April 2003, 22:45 GMT
Reason for closing:  Fixed
Comment by Björn Stenberg (zagor) - Wednesday, 12 February 2003, 09:10 GMT

Good catch! Fixed.