Rockbox

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by William Poetra Yoga Hadisoeseno - 2008-06-23
Last edited by Marcoen Hirschberg - 2008-06-23

FS#9112 - Automatically set correct cross compiler path based on user configuration file.

This is an attempt to automate the setting of $PATH in tools/rockboxdev.sh, tools/configure and the generated Makefile.

The directory prefix of the cross compilers is stored in ~/.config/rockbox.org/RockboxCompilerPrefix. As the default path (in tools/rockboxdev.sh) is /usr/local, if that file is empty, then $PATH won’t be modified. Otherwise, the value stored inside that file will be read, the target platform type appended, and lastly /bin appended. The resulting string will be appended to $PATH.

This patch doesn’t break existing configuration. But it’s most probably incomplete, so please provide feedback on which files need to be modified as well.

Jonas Häggqvist commented on 2008-06-24 22:58

Wouldn’t it be better to prepend the path to PATH, to avoid rogue crosscompilers causing trouble?

William Poetra Yoga Hadisoeseno commented on 2008-06-25 01:23

Good idea. This patch does that, prepending the cross compiler path to PATH instead of appending to it.

Admin
Frank Gevaerts commented on 2008-06-26 12:45

Actually I prefer the original. I’d like to keep the ability to override this by setting PATH

edit: of course those people who know how to use PATH properly can just ignore the issue by not creating the settings file.

Admin
Frank Gevaerts commented on 2008-06-26 12:54

Also, maybe a different filename is better. It’s not inconceivable that at some point people will want to add other settings, and RockboxCompilerPrefix will be a bit too specific then

William Poetra Yoga Hadisoeseno commented on 2009-05-10 03:44

Here’s an updated version, sync’ed with latest SVN.

Gevaerts, regarding your comments:
1. I’m neutral as to whether we should add the new path before PATH or after PATH. I don’t see any strong benefit in either way, so I’m keeping the current behaviour for now.
2. For the filename thing, I think other settings should be created in other files, inside the ~/.config/rockbox.org directory. What do you think?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing