• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by stripwax - 2008-07-08
Last edited by saratoga - 2008-07-28

FS#9170 - Patches to fix profile builds , profile behaviour , profile_reader tool

Fixes #define clash between profiling code and sudoku plugin

Fixes profile instrumentation function names to match what gcc expects (please can someone confirm on a non-cygwin build environment that this does indeed also work for them)

Fixes profiling code to pass required CPU/COP arg to timer_register() on devices with cop

Fixes profile_reader to execute the correct objdump executable (⇒ now passed on command line as new required argument - e.g. “profile_reader profile.out arm-elf-objdump …“)

Adds error message when no output sort order is specified (no order ⇒ no output! confusing to just get no output and no explanation why not)

Fixes sort order in profile_reader output (wasn’t sorting numeric fields numerically before, or at least not correctly!)

Fixes linked list depth always being zero in output (column: “DEPTH” value always 0000 - recursive print code was recursing with depth++ rather than ++depth!!)

Then also some probably more contentious changes:
When profiling build is enabled, don’t build alac.codec, doom, and mpegplayer. These cannot link on ipod video builds due to iram usage of profiling code

Closed by  saratoga
2008-07-28 22:47
Reason for closing:  Accepted

Looks like the generator.c diff is no longer required, presumably the conflicting #define got moved since I started the patch.
Updated patch attached


Available keyboard shortcuts


Task Details

Task Editing