FS#9170 - Patches to fix profile builds , profile behaviour , profile_reader tool

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Tuesday, 08 July 2008, 23:34 GMT
Last edited by MichaelGiacomelli (saratoga) - Monday, 28 July 2008, 22:47 GMT
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Fixes #define clash between profiling code and sudoku plugin

Fixes profile instrumentation function names to match what gcc expects (please can someone confirm on a non-cygwin build environment that this does indeed also work for them)

Fixes profiling code to pass required CPU/COP arg to timer_register() on devices with cop

Fixes profile_reader to execute the correct objdump executable (=> now passed on command line as new required argument - e.g. "profile_reader profile.out arm-elf-objdump ...")

Adds error message when no output sort order is specified (no order => no output! confusing to just get no output and no explanation why not)

Fixes sort order in profile_reader output (wasn't sorting numeric fields numerically before, or at least not correctly!)

Fixes linked list depth always being zero in output (column: "DEPTH" value always 0000 - recursive print code was recursing with depth++ rather than ++depth!!)

Then also some probably more contentious changes:
When profiling build is enabled, don't build alac.codec, doom, and mpegplayer. These cannot link on ipod video builds due to iram usage of profiling code
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Monday, 28 July 2008, 22:47 GMT
Reason for closing:  Accepted
Comment by Dave Hooper (stripwax) - Sunday, 20 July 2008, 14:29 GMT
Looks like the generator.c diff is no longer required, presumably the conflicting #define got moved since I started the patch.
Updated patch attached