• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by ThibG - 2008-07-09
Last edited by shotofadds - 2008-07-16

FS#9178 - lcd_blit_yuv and lcd_write_yuv420_lines2 functions for Cowon D2

Provide a basic (extremly slow) lcd_write_yuv420_lines for the Cowon D2 and update the lcd_blit_yuv function.

Closed by  shotofadds
2008-07-16 17:40
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

In r18060.

ThibG commented on 2008-07-09 18:39

Ignore the old patch, this one is much faster.

ThibG commented on 2008-07-09 20:04

Another patch :)

MikeS commented on 2008-07-09 21:39

Why not modify lcd-as-memframe.S since it’s in use for general RGB updates for the D2 anyway? The asm yuv stuff should only need a few instructions changed to allow non-rotated conversion. mpegplayer also needs to be told explicitly that dithering is available for the target.

Mike, that’s the intention. This was accepted as a stop-gap until either I have the time to fix it properly (not a priority) or someone else with the relevant ARM knowledge comes along and does so.

ThibG commented on 2008-07-11 08:37

Here is a new patch, which make the ASM part draw lines horizontally when LCD_HEIGHT < LCD_WIDTH

The attached patch updates both the standard and dithered versions (lcd_yuv_write_42_lines_odither) to only rotate if LCD_HEIGHT > LCD_WIDTH, and also enables the Dithering option in MpegPlayer for the D2.

I’ve simplified the previous patch slightly by removing the LCD_WIDTH < 128 stuff (since no targets using this code have a resolution that small) and included a slight optimisation for an extra 1fps.


Available keyboard shortcuts


Task Details

Task Editing