Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Applications
  • Assigned To
    nicolas_p
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2008-07-15
Last edited by fml2 - 2010-10-11

FS#9197 - Return correct failure code if the WPS has too many viewports

The title says it all, I have nothing to add

Closed by  fml2
2010-10-11 14:56
Reason for closing:  Rejected
Additional comments about closing:  

A very old patch; obsoltete by now

Have you tested this patch? I don’t think it will work correctly, because the value of PARSE_FAIL_LIMITS_EXCEEDED is positive, whereas parsing functions like parse_viewport are supposed to return either the number of characters they read or a strictly negative error value. Maybe there is no apparent problem (thanks to the other check for the viewport limit), but this looks wrong to me.

fml2 commented on 2008-07-16 05:23

To be honest, I have not tested the patch. I just have seen that a wrong literal is used in this case and have assumed that the general frame is correctly set up. If it’s not, then a fix is needed at another place (but this fix is still correct IMHO).

fml2 commented on 2008-07-16 18:39

Here is another try. Now also tested, although not very extensively. Also added some comments.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing