FS#9203 - WPS gets corrupted after changing status bar setting

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Friday, 18 July 2008, 08:55 GMT
Last edited by Bertrik Sikken (bertrik) - Monday, 04 August 2008, 17:46 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The WPS gets corrupted when changing the status bar setting. This even happens when changing the status bar setting from yes to no then canceling the setting. The symptom is that the WPS elements seem to be shifted down (by the amount of the height of the status bar?). I've noticed this on sansa c200 and e200.

How to reproduce:
* select a theme containing a status bar (e.g. cabbiev2)
* go to display settings, status bar, select no but cancel the setting
(display flashes briefly, as if a display setting was updated)
* go to the WPS
->WPS elements are shifted down
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Monday, 04 August 2008, 17:46 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed as r18192, thanks for the fix.
Comment by Thomas Schott (scotty) - Monday, 04 August 2008, 15:28 GMT
reproduced on iPod Color

The good news: Only 1 if statement needs to be changed in the statusbar_toggle_handler() to fix this :-)
<global_settings.statusbar> is already checked at the definition of <draw> and should only effect the viewport settings if no <wps_sb_tag> is defined for the current wps.