Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Defer
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Domonoky - 2008-07-23
Last edited by Domonoky - 2008-07-26

FS#9210 - ASAP plugin

Hi,

i made a first attempt for a ASAP (http://asap.sourceforge.net/) port to Rockbox.
This is a very crude port of the asap2wav program to a rockbox plugin.
It works as a Viewer and converts a .sap file to “test.wav” in the root folder. (test.wav has to exist before).

On Simulator it works nicly, but not on Target.
It tested it on a m:robe100 and it runs without error, but does not produce correct sound.
I only get loud cracking and such in the wav file.

I suspect this is because of some endianess problems. (our targets are big-endian, where pc is little-endian).
EDIT: m:robe100 is LE, so it cant be endian problems.

At the moment i dont know where and how to attack this problem, as the asap code seems to have nearly no way to tell if something is gone wrong. (and its full of a MACRO hell )

so if others want to join the fun, jump in :-)

   asap.patch (613.1 KiB)
Closed by  Domonoky
2008-07-26 15:43
Reason for closing:  Accepted
linuxstb commented on 2008-07-23 20:03

I also did the same thing… Here’s my attempt (just the apps/plugins/asap2wav/ directory, not a patch).

(application/x-gzip)    asap2wav.tgz (41.1 KiB)
Domonoky commented on 2008-07-25 19:24

Here is now a patch with asap as a codec.

Its still very early, no metadata parser is in place, so songlengh others are fake.

But it plays sound without problems. I tested on sim and on m:robe100.
On m:robe100 i got ~850% realtime. so no performance problems :-)

edit:
forgot to remove the memset.
delete line 118 in apps/codecs/asap.c

   asap_codec.patch (424.2 KiB)
Domonoky commented on 2008-07-25 19:59

i think i messed up the patch.
new try:

   test-codec2.patch (216.4 KiB)
bertrik commented on 2008-07-25 22:06

Attached is a fixed test-codec2.patch (apps/codecs/asap.c was missing)

   test-codec2-fixed.patch (219.8 KiB)
RMenes379 commented on 2008-07-25 22:25

bertrik’s patch worked successfully. I managed to compile a working build with SAP support on my Sansa c240.

I get ~160.19% realtime, according to test_codec.

Decode time - 16.23s
File duration - 26.00s

Domonoky commented on 2008-07-25 22:38

last patch for today.

now with metadata parser.

elapsed_time and sub_songs, seeking handling still missing.

   asap_codec3.patch (223.9 KiB)
Domonoky commented on 2008-07-26 13:24

Now it plays and seeks correctly.
Only thing missing is SubSong handling. At the moment it always plays the default song.

Edit:
small fix, so it correctly works on big-endian targets.

   asap_codec4.patch (223.5 KiB)
   asap_codec5.patch (224.1 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing