Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Codecs
  • Assigned To No-one
  • Operating System iPod 1G/2G
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by yapper - 2008-07-27
Last edited by linuxstb - 2008-07-27

FS#9216 - Data abort error playing SAP files

Attempting to play SAP files using r18125 gives data abort. I’ve tried multiple files from http://asma.atari.org/ and all fail in the same way.

Closed by  linuxstb
2008-07-27 10:50
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Fixed in SVN r18126

bluebrother commented on 2008-07-27 07:25

This seems to be a metadata issue – if the database tries updating the system crashes with a data abort immediately. Reproducable on e200, mr100 and mini2g.

linuxstb commented on 2008-07-27 07:28

I haven’t tested, but a possible fix could be to change line 233 of apps/metadata/asap.c from:

info = (struct module_info *) buf;

to

info = (struct module_info *) ((buf + 3) & ~0×3); /* Align struct to 4-byte boundary */

yapper commented on 2008-07-27 10:16

@Dave:
I get ‘metadata/asap.c:233: error: invalid operands to binary &’ with your suggested fix.

linuxstb commented on 2008-07-27 10:50

I was missing a typecast - I’ve now tested this fix, and it seems to work, so I’ve committed it to SVN and will close this task.

If anyone gets more data aborts, please request this task is re-opened.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing