Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2008-08-03
Last edited by bertrik - 2008-08-03

FS#9237 - Mismatch in voiced and displayed buffer size

I noticed that the buffer size displayed in System/Rockbox info is different from the size that is spoken. The ratio is 1.024 (i.e. the ratio between a KB and KiB).

Attached patch fixes this by using function output_dyn_value for both displaying and voicing of the buffer size.

This patch touches english.lang and removes conversion specifier (like %03d) from a string. I’m not sure about the impact of this on other languages, they may have to be updated too.

   speak_buffer_size.patch (1.8 KiB)
Closed by  bertrik
2008-08-03 22:13
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as 18190. Languages using LANG_BUFFER_STAT have been updated to use output_dyn_value instead of doing a sprintf.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing