FS#9237 - Mismatch in voiced and displayed buffer size

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Sunday, 03 August 2008, 18:37 GMT
Last edited by Bertrik Sikken (bertrik) - Sunday, 03 August 2008, 22:13 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I noticed that the buffer size displayed in System/Rockbox info is different from the size that is spoken. The ratio is 1.024 (i.e. the ratio between a KB and KiB).

Attached patch fixes this by using function output_dyn_value for both displaying and voicing of the buffer size.

This patch touches english.lang and removes conversion specifier (like %03d) from a string. I'm not sure about the impact of this on other languages, they may have to be updated too.

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Sunday, 03 August 2008, 22:13 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed as 18190. Languages using LANG_BUFFER_STAT have been updated to use output_dyn_value instead of doing a sprintf.