Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Bootloader
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by vitja - 2008-08-06
Last edited by linuxstb - 2008-09-06

FS#9245 - [iaudio7] basic support

Hi!

This patch adds basic support for iaudio7 device.
This includes LCD driver, incomplete buttons driver (sensor panel doesn’t work yet).

With this patch bootloader can be build.

vitja.

Closed by  linuxstb
2008-09-06 20:59
Reason for closing:  Accepted
Additional comments about closing:  

iaudio7-6sep.diff committed as r18435

vitja commented on 2008-08-11 05:37

Updated version:

- coldstart LCD initialization now works.
- Basic support for playback based on pcm-tcc780.c, somewhy I can't get FIQ to be triggered now, but with IRQ it works. And the I fill buffer with the tone, and I hear it in headphones.
- NAND flash still doesn't works, it can't find partition data it read are all 0xff

- I found some problems with app.lds and DTCM, I made new one from boot.lds very simple, but rockboxs boot and says that flash should be formated.

now I'm going to vacations for ~2weeks

vitja.

vitja commented on 2008-08-11 06:30

Here is some my work on usb driver.

It is in very early stage, but it contains register definition and masks of some bits.
Also providing some environment for debugging driver the same.

vitja.

vitja commented on 2008-08-27 13:40

Update:

- ATA2501 support, main buttons now work too
- Initial Rockbox support (rockbox runs)
- Playback is buggy, but work sometimes
- RTC seems to work
- NAND flash driver work sometimes, same issues as with D2

Good work! I've had a quick look at your patch with a view to getting it committed into SVN, and have the following comments so far:

1. There are some TABs in this patch - please replace them with 4 spaces (see guidelines in docs/CONTRIBUTING)
2. In pcm-telechips.c I think you should use "#ifdef CPU_TCC780X" and "#ifdef CPU_TCC77X" instead of COWON_D2 and IAUDIO_7
3. The MODEL_NUMBER should probably be the next available number rather than 555 ;-) 4. There's some "dead" code (eg. PCM_TELECHIPS_TEST and commented-out lines in the keymaps) which should be removed before committing.
5. tcc77x.h has a lot of empty comments (ie. /* … */). Remove these or fill in a real description.
6. Please don't put whitespace in pre-processor commands (e.g. "# if" in bootloader/telechips.c)
7. Update the comment in config-iaudio7.h that says "The D2 uses a WM8985 codec"
8. Some of the file headers don't include the necessary "$Id$" line for SVN version information

Note: I have not tested the 77x and 78x changes (pcm, bootloader) on target yet.

vitja commented on 2008-09-03 11:03

Hi Rob!

I've updated patch as you said.
But have some notes:

1. Ok
2. Different Player require different DAO setup so it should be done per-player not per-cpu
3. Ok
4. "dead" code may be very useful while debugging on new target. I leave commented buttons in keymap for future keymap improvement.
5. Ok
6. I think this is good way to keep preprocessor directives more readable. Some other rockbox files use these spaces too.
7. Ok
8. Ok

Thanks,
vitja.

You're right, of course the I2S setup is dependent on both CPU and DAC, so those player #ifdef's are fine. I wouldn't worry about those commented-out lines in the keymaps (assuming somebody intends to fix them later).

Personally I don't like those spaces in the preprocessor directives - but maybe ask in IRC and see what others think?

Admin
fg commented on 2008-09-03 18:21

If you do further USB work, could you change the register definitions to be base-address agnostic, i.e. define something like USB_BASE in tcc77x.h and use USB_BASE+offset ? Other SoCs use the same controller

vitja commented on 2008-09-05 09:18

Update:

- add usb register definition relative to USB_BASE
- disable usb device in usb_init_device()
- power_off() from cowond2

vitja commented on 2008-09-05 11:25

Update:

- switch on and off sensor-panel leds when switching backlight
- initial tunner support driver detects tunner, but it doesn't work now

vitja commented on 2008-09-06 06:02

Update:

- Radio now works, but rockbox sometimes crashes with divide by zero exception
- Dummy funcs for recording, enabling recording gives monitor mode available for radio
- Initial keymap for plugins
- Fix hold button issue

- It seems that color conversion is wrong. We need to convert RGB16 to RGB18 that doesn't work always correctly

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing