Rockbox

  • Status Assigned
  • Percent Complete
    0%
  • Task Type Patches
  • Category User Interface → Simulator
  • Assigned To
    Tomer Shalev
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Future release
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Tomer Shalev - 2008-08-08
Last edited by Tomer Shalev - 2009-12-15

FS#9252 - Common keyboard actions for Simulator

Note: This is work in progress.
Status: Code implemented

      Manual not updated
      Wiki not updated (only after commit)

The idea of this patch is to have the same keyboard keys assign to the same actions in all platforms.

For example, have +/- keys (both on keyboard and on Numpad) are assigned to Volume Up and Volume Down keys of the original platform.
For platforms which do not have these keys, pressing the +/- keys in the simulator will do nothing.

This change will help developers to do manual regression testing on lots of platforms easily, as they do not have to memorize each platform’s key assignment.

Future development: Display key assignment on screen, and/or on console

Steve Bavin commented on 2008-08-08 11:28

You can already display the key assignment in the simulator if you use the –background option.

Also, the simulators should be consistent with the corresponding device only, not with each other (if that makes sense).

Thomas Martitz commented on 2008-08-08 12:15

I think the simulator in particular should be consistent over all targets. As long as it has all buttons the device has, it is consistent enough with the targets, imho.

Tomer Shalev commented on 2008-09-07 13:01

Synced and modify patch

Now displays keyboard assignment on console on load, and when pressing the ‘?’ key.

Moved target specific key assignments from button.c to uisdl.h.

Tested on various targets.

Maurus Cuelenaere commented on 2008-09-11 11:08

Seems like a good idea to me, but I’m not sure what this has to do:

#ifdef HAVE_TOUCHSCREEN

      printf("A, End\n", UI_KEY_SPECIAL_STR);

#else

      printf("A, End; Keypad 1 (END)\n", UI_KEY_SPECIAL_STR);

#endif

Shouldn’t there be a %s somewhere in that printf()?

Tomer Shalev commented on 2008-09-11 11:19

Thanks for this info. I’ve attached a fixed patch.

Note that we should also update the background images of various players, as the former key used are shown on each image.
I have no clue as to where the original images without these labels are, if there are such images at all.

Hopefully, when this patch is committed, we should also update the Twiki page, and remove the shortcut keys shown there (http://www.rockbox.org/twiki/bin/view/Main/UiSimulator).

Maurus Cuelenaere commented on 2008-09-11 11:21

About the images: I’m afraid the originals aren’t stored anywhere easily accessible; so you’ll have to either manually edit them or find new ones..

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing