Rockbox

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Uchida - 2008-08-08

FS#9253 - logf file output patch.

It is a patch that can automatically output the result of logf to the
file.

The setting of default doesn’t output the result of the logf to the
file.
Please set and do the following when it is effective. 

System > Debug > logf auto file output: select "Yes"
   logf_output.patch (35.7 KiB)
nicolas_p commented on 2008-08-08 14:36

Are you sure a whole new set of file functions is needed? Also, did ou write all of asyncfile.c?

Uchida commented on 2008-08-10 14:46

If asyncfile.c was not used when the log is output to the file,
then it not be output to the file or only a part of the log be output
when the load of Rockbox is high (playing music or movie).

The patch file to output the log to the file without using asyncfile.c was prepared,
and confirm the output of the log is different, please.

Uchida commented on 2008-08-10 14:59

Sorry, I don’t send patch file.

fs_logf_no_asyncfile.patch
　It is a patch file to output the log to the file without using asyncfile.c.

rev_logf.txt 

It is a file that upsets the top and bottom of the line to the execution result of logfdump(logf.txt).

logf.log
　It is a log file that Rockbox that applied fs_logf_no_asyncfile.patch.

When it compare rev_logf.txt with logf.log,
The 635-660th line and the 681-683th line of rev_logf.txt is
different from logf.log. 


								    

          
              
              
            fs_logf_no_asyncfile.patch
                  
                  (5.3 KiB)
              

          
              
              
            rev_logf.txt
                  
                  (27.2 KiB)
              

          
              
              
            logf.log
                  
                  (21.9 KiB)
              

    

  			

		

	

	

		

		

			

				

				
																		

				

				
pyro_maniac commented on 2009-03-10 16:49

			

			

				


I attached a file with a actual and minimal version but i didn’t had the chance to test it enoght.



								    

          
              
              
            file_log.patch
                  
                  (3.4 KiB)
              

    

  			

		

	

	

		

		

			

				

				
																		

				

				
Uchida commented on 2009-03-11 14:22

			

			

				


Processing slows very much when the log is effective because logf() doesn’t end if writing in the file is not completed.
For example, when the log is output when a music has been played, the slowness of processing can be experienced. 
Because processing is not slowed down when the log is output, the asyncfile.c is needed. 





My patch file cannot be applyed in the Rockbox of the latest version. 
Ｉｆ the new patch file is necessary, please wait for the patch file that can be appropriated to the latest version.



											

		

	

	

		

		

			

				

				
																		

				

				
pyro_maniac commented on 2009-03-11 14:56

			

			

				


so i will wait for a new patch to come along with my port. Thanks for doing this.



											

		

	

	

		

		

			

				

				
																		

				

				
Uchida commented on 2009-03-12 12:42

			

			

				


I corrected my patch file to apply it to the Rockbox of the latest version.
Please report on the operation when this patch is used. 



								    

          
              
              
            logf_output_2.patch
                  
                  (7.3 KiB)
              

    

  			

		

	

	

		

		

			

				

				
																		

				

				
pyro_maniac commented on 2009-03-12 19:56

			

			

				


There are still several bugs in. asyncfile.c is inserted in SOURCES but there is no file. The boolean in settings.h is in the enum.



											

		

	

	

		

		

			

				

				
																		

				

				
Uchida commented on 2009-03-21 14:27

			

			

				


Sorry, my patch file build failure. 
It updates. I think that the Rockbox firmware build success. 


								    

          
              
              
            logf_output_3.patch
                  
                  (34.2 KiB)
              

    

  			

		

	

	

		

		

			

				

				
																		

				

				
pyro_maniac commented on 2009-03-21 18:46

			

			

				


There are still some warnings on applying but it works for me. Thanks for help!



											

		

	

	

		

		

			

				

				
																		

				

				
Uchida commented on 2009-03-26 11:00

			

			

				


sync r20543.
I confirmed the build was able to be done to iPod video, iriver H120 and Sansa e200. 


								    

          
              
              
            logf_output_4.patch
                  
                  (34.3 KiB)
              

    

  			

		

	

	

		

		

			

				

				
																		

				

				
pyro_maniac commented on 2009-03-26 12:20

			

			

				


Patch 3 works on a h10 5g build too.



											

		

	







Loading...










Available keyboard shortcuts





Tasklist



Task Details



Task Editing