Rockbox

  • Status New
  • Percent Complete
    0%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by learman - 2008-08-27

FS#9329 - Remove total tracks and total discs from ID3v2 tags.

This patch removes any total tracks and total discs number from the track and disc number fields in ID3v2 tags, so that track and disc numbers are displayed consistently across different tagging formats.

What happens is that if a number larger than zero can be parsed from the start of the field, then the field is terminated on the first “/” char.

Added as a patch as I don’t know if this behavior is wanted.

   id3_num.patch (1.1 KiB)
Llorean commented on 2008-08-27 20:19

Personally, I’d prefer to trust users to put the information in their tag that they want to be displayed.

Realistically, I expect more reports like the one that prompted you to post the patch rather than just use it yourself if we don’t include this behaviour.

Any chance you know of a specification somewhere that says the “Track” and “Disc number” fields are supposed to be numeric, or supposed to not contain total tracks, or anything else that would help justify this?

rasher commented on 2008-08-27 20:24

http://id3.org/id3v2.4.0-frames

TRCK 

 The 'Track number/Position in set' frame is a numeric string containing the order number of the audio-file on its original recording. This MAY be extended with a "/" character and a numeric string containing the total number of tracks/elements on the original recording. E.g. "4/9".

TPOS 

 The 'Part of a set' frame is a numeric string that describes which part of a set the audio came from. This frame is used if the source described in the "TALB" frame is divided into several mediums, e.g. a double CD. The value MAY be extended with a "/" character and a numeric string containing the total number of parts in the set. E.g. "1/2".

Not exactly what you hoped for.

funman commented on 2008-12-11 17:07

I understand that “/ total” is wanted and this patch is incorrect

rasher commented on 2008-12-11 17:08

I think this should be closed - Lear?

learman commented on 2008-12-12 17:57

If total is wanted, shouldn’t a totaltracks field be added then (and totaldiscs?), so that it can be displayed for non-ID3v2 formats too?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing