FS#9333 : pictureflow: buffer overflow when track number is over 50

Status Closed
Percent Complete
100%
Task Type Bugs
Category Plugins
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by tomkiewicz - 2008-08-28
Last edited by Unhelpful - 2009-05-16

FS#9333 - pictureflow: buffer overflow when track number is over 50

When ID3 tag track number is greater than 50 (ie. some bonus tracks are ripped with “99” track number), there is buffer overflow. When user enters the album with such track, there are about 32 more “tracks”, but with crappy titles.

I’ve made patch that solves this bug and tested it with and without http://www.rockbox.org/tracker/task/9331 - both works OK

pf_buffer_overflow.diff (2.2 KiB)

Closed by Unhelpful
2009-05-16 02:46
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Fixed as of r20938.