Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#9333 : pictureflow: buffer overflow when track number is over 50

Rockbox

Tasklist

FS#9333 - pictureflow: buffer overflow when track number is over 50

Attached to Project: Rockbox
Opened by Tomasz Wasilczyk (tomkiewicz) - Thursday, 28 August 2008, 14:46 GMT
Last edited by Andrew Mahone (Unhelpful) - Saturday, 16 May 2009, 02:46 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When ID3 tag track number is greater than 50 (ie. some bonus tracks are ripped with "99" track number), there is buffer overflow. When user enters the album with such track, there are about 32 more "tracks", but with crappy titles.

I've made patch that solves this bug and tested it with and without http://www.rockbox.org/tracker/task/9331 - both works OK
   pf_buffer_overflow.diff (2.2 KiB)
This task depends upon

Closed by  Andrew Mahone (Unhelpful)
Saturday, 16 May 2009, 02:46 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed as of r20938.
Comment by Tomasz Wasilczyk (tomkiewicz) - Thursday, 28 August 2008, 15:07 GMT
uhh, I've removed one empty line by accident - here is fixed patch
   pf_buffer_overflow_v2.patch (2.1 KiB)

Loading...