• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2008-08-30
Last edited by bagder - 2008-12-01

FS#9338 - Fix

This patch fixes the following issue:

1. When gmake is missing, `which qmake` produces error message.

 Therefore changed to `which gmake 2> /dev/null`

2. mkdir $builddir is called only if that directory is not previously exists. This happens when the user selects 'all' architectures, and builddone() is called more than once.

3. Instead of download all needed files, then extract all of them, I changed behavior to download & extract each file. This makes code prettier.

4. Added -N parameter to 'patch' so that it patches only if files are not already patched, and ignore otherwise, without asking the user whether it is a reversed patch.

Closed by  bagder
2008-12-01 13:26
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Thanks, I did the gmake stderr fix and the others I didn't particularly like so I didn't apply them!

Please don't combine actual fixes to problems with personal preferences for code prettiness improvements.

Patches should address one issue each. Fixing bugs is one issue (well not really, since each is a separate bug, but it can be justified as such), "make it look nicer" is a separate thing entirely.


Available keyboard shortcuts


Task Details

Task Editing