Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2008-09-01
Last edited by nicolas_p - 2008-09-06

FS#9350 - Fix WPS crash on some simple tags

There is a bug in the WPS interpreter. How to reproduce:

Create a simple WPS containing just one of the following tags (standalone, not as a conditional switch): %mm, %mp

As soon as WPS screen is shown, I get segmentation fault. I didn’t try it on the target, only on the sim.

Attached is the correcting patch.

Closed by  nicolas_p
2008-09-06 17:44
Reason for closing:  Accepted
Additional comments about closing:  

r18420 + r18421

This also affects WPS editor.

I committed the bugfix but decided to leave the function out… IMHO it didn’t help code readability.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing