• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Uchida - 2008-09-02
Last edited by speachy - 2020-07-03

FS#9354 - iso_decode function illegal address access


 iso_decode(const unsigned char *iso, unsigned char *utf8, int cp, int count) (in firmware/common/unicode.c),

if count > strlen(iso), then “iso” accesses an illegal address. Therefore, a fatal error might occur.

Closed by  speachy
2020-07-03 03:44
Reason for closing:  Not a Bug
Project Manager

That is correct, thanks for pointing it out.

However, we have plenty of code in Rockbox without bounds checking. The philosophy is that we generally don’t want to waste code space with unnecessarily defensive programming.

Have you discovered a crash in Rockbox caused by iso_decode()?

What is your real name, so I can give you proper credit?

Fortunately, a fatal error has not been seen to occur.

I check the source that uses iso_decode(), because of it is sizeof(iso) >= count,
an illegal address is not accessed.

I’m sorry firing.

Finally, my real name is “Yoshihisa Uchida”.


Available keyboard shortcuts


Task Details

Task Editing