Rockbox

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2008-09-02

FS#9356 - Allow to set the delay before button repeat is activated (=long button press)

The patch allows to set the delay after which the button repeat event is generated. Since this event is used to detect a long button press, it effectively sets this 'threshold.'

Slow fingered users may often hold the select button too long and (unintentionally) get the context menu. For instance, from the WPS screen. But they actually wanted to go to the file browser.

The patch adds a setting for that delay. Its default value is 30 ticks (=0.3s). The menu entry is in Settings → General Settings → System → Long Button Press Duration.

   btn_long_press.patch (5 KiB)
fml2 commented on 2008-09-03 18:50

Here are the contents of the file rockbox-info.txt without and with the patch (to see how it affects the bin size etc).

Clean rb:

Target: h120
Target id: 9
Target define: -DIRIVER_H120
Memory: 32
CPU: coldfire
Manufacturer: iriver
Version: r18398-080903
Binary: rockbox.iriver
Binary size: 396464
Actual size: 396456
RAM usage: 830672
Features: agc:backlight_fade:dircache:hold_button:lcd_bitmap:lcd_non-mono:lcd_flip:lcd_invert:pitchscreen:quickscreen:radio:recording:recording_swcodec:remote:remote_lcd_invert:remote_ticking:spdif_power:swcodec:tagcache:tc_ramcache:charging
gcc: m68k-elf-gcc (GCC) 3.4.6
ld: GNU ld version 2.16.1
Host gcc: gcc (GCC) 4.2.3 (Ubuntu 4.2.3-2ubuntu7)
Host system: Linux

With FS#9356

Target: h120
Target id: 9
Target define: -DIRIVER_H120
Memory: 32
CPU: coldfire
Manufacturer: iriver
Version: r18398M-080903
Binary: rockbox.iriver
Binary size: 396608
Actual size: 396600
RAM usage: 830824
Features: agc:backlight_fade:dircache:hold_button:lcd_bitmap:lcd_non-mono:lcd_flip:lcd_invert:pitchscreen:quickscreen:radio:recording:recording_swcodec:remote:remote_lcd_invert:remote_ticking:spdif_power:swcodec:tagcache:tc_ramcache:charging
gcc: m68k-elf-gcc (GCC) 3.4.6
ld: GNU ld version 2.16.1
Host gcc: gcc (GCC) 4.2.3 (Ubuntu 4.2.3-2ubuntu7)
Host system: Linux

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing