Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Domonoky - 2008-09-03
Last edited by Domonoky - 2008-09-10

FS#9362 - WPS Editor: Add linenumbers and highline line with error

This patch changes the WPS code view of the WPS Editor.

I used Code from KDE Libs and simplified it for use with this.
Now the WPS Editor shows Line numbers for the WPS, and it highlights the line where it finds an error.

   wpseditor-linenumber.patch (16.5 KiB)
Closed by  Domonoky
2008-09-10 19:41
Reason for closing:  Accepted
mcuelenaere commented on 2008-09-04 12:28

Very nice!

I was going to implement the line numbering myself, but couldn't find a good example implementation..

One thing though, perhaps the highlighted error should be in redish, so it's more visible.
And perhaps you can get the widget to scroll to the appropriate line number?

edit:
I've attached a patch

   wpseditor_linenumber2.diff (16.6 KiB)
krz commented on 2008-09-04 20:06

Scrolling to line added.
Clear error line after wps-text was modified.

   wpseditor_linenumber3.diff (18.6 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing