FS#9363 : WPS editor build cleanup

Status Closed
Percent Complete
100%
Task Type Patches
Category User Interface → Themes
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by mcuelenaere - 2008-09-04
Last edited by mcuelenaere - 2008-09-04

FS#9363 - WPS editor build cleanup

This patch changes the build behaviour as discussed in #rockbox-community.

It's only for WPS editor, checkwps is unchanged.

Closed by mcuelenaere
2008-09-04 14:50
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

In r18407.

Comments (5)
Related Tasks (0/0)

fg commented on 2008-09-04 12:35

With careful/conditional setting of LDFLAGS it should be possible to unify the libwps_%.dll and libwps_%.so targets I think. (It would then be libwps_%$(EXE) of course) That would further simplify the makefile

mcuelenaere commented on 2008-09-04 13:26

This simplifies the Makefile.

Libwps still isn't build when doing 'qmake-qt4 && make' in the root dir though..

wpseditor_build_cleanup2.diff (27.9 KiB)

fg commented on 2008-09-04 13:39

$(RM) $(RESULTS) instead of $(RM) libwps_* ?

edit: same for $(COPY) I guess

fg commented on 2008-09-04 14:28

Adding libwps to the SUBDIRS line in wpseditor.pro seems to get qmake to do the right thing

mcuelenaere commented on 2008-09-04 14:43

Contains the fixes gevaerts suggested.

wpseditor_build_cleanup3.diff (27.9 KiB)