Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mcuelenaere - 2008-09-04
Last edited by mcuelenaere - 2008-09-04

FS#9363 - WPS editor build cleanup

This patch changes the build behaviour as discussed in #rockbox-community.

It's only for WPS editor, checkwps is unchanged.

Closed by  mcuelenaere
2008-09-04 14:50
Reason for closing:  Accepted
Additional comments about closing:  

In r18407.

Admin
fg commented on 2008-09-04 12:35

With careful/conditional setting of LDFLAGS it should be possible to unify the libwps_%.dll and libwps_%.so targets I think. (It would then be libwps_%$(EXE) of course) That would further simplify the makefile

This simplifies the Makefile.

Libwps still isn't build when doing 'qmake-qt4 && make' in the root dir though..

Admin
fg commented on 2008-09-04 13:39

$(RM) $(RESULTS) instead of $(RM) libwps_* ?

edit: same for $(COPY) I guess

Admin
fg commented on 2008-09-04 14:28

Adding libwps to the SUBDIRS line in wpseditor.pro seems to get qmake to do the right thing

Contains the fixes gevaerts suggested.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing