Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Games
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Frank Gevaerts - 2008-09-08
Last edited by Teruaki Kawashima - 2009-12-12

FS#9380 - spacerocks shows funny rocks

Sometimes the rocks shown have wrong edges (see screenshots). The lines jump between different points while rotating.

I’ve seen this on H100, H300 and X5

   rocks1.jpg (229.4 KiB)
   rocks2.jpg (252.5 KiB)
Closed by  Teruaki Kawashima
2009-12-12 14:11
Reason for closing:  Fixed
Additional comments about closing:  

Fixed in r23944.

Nils Wallménius commented on 2008-10-03 08:25

Hi, I committed a fix to the 16 bits lcd driver which fixed one problem with spacerocks in the sim but i have been unable to reproduce this on target.

Admin
Frank Gevaerts commented on 2008-10-08 19:00

It’s not fixed in r18691 (your lcd fix)

Nils Wallménius commented on 2008-10-09 16:52

Yes, I was able to reproduce this on my h300 finally.
I tried letting it run in the h300 sim for a long while too and observed an interesting effect, some of the rocks keep increasing in size and get so big they are mostly outside the display all the time.

Tomer Shalev commented on 2008-10-09 18:44
some of the rocks keep increasing in size and get so big they are mostly outside the display all the time.

This happens due to the way the rock’s vertices are being rotated. There is an accumulating error which affects the shape of the rocks.

The reason is due to the way the vertices are being sined and cosined, by being multiplied with a constant of a four digits accuracy.
The error is not being reset at all, even if the asteroid completes a full round…

See code at:
http://svn.rockbox.org/viewvc.cgi/trunk/apps/plugins/spacerocks.c?view=markup

I’m developing a new game, partly based on spacerocks, and I fixed this error in my code. When I find the time, I’ll fix spacerocks either.
If anyone is interesting, I can attach my draft code here.

Nils Wallménius commented on 2008-10-20 19:12

Tomer, if you would post your work somewhere and point out what the fix is I could try to incorporate it into spacerocks.
Btw I reproduced this on my Gigabeast so the title was incorrect, and will be changed soon.
Also I noted that the rocks first got bigger and then turned into funny shapes so it seems related.

Teruaki Kawashima commented on 2009-12-10 14:41

I made a fix for this issue. this seems to work to me on my gigabeat x.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing