FS#9421 - "Official" release not OK

Attached to Project: Rockbox
Opened by Eric Lassauge (lassauge) - Friday, 26 September 2008, 08:27 GMT
Last edited by Nils Wallménius (nls) - Wednesday, 08 October 2008, 19:31 GMT
Task Type Bugs
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Wrong or missing links in website for 'official 3.0':
- on main page the link 'Rockbox 3.0 is released!' goes to where it is said: 'There is no "current" release'. However the 3.0 is available at ''

- rockbox-3.0.7z tarball (7zipball ?) has also some problems:
* Zip file should contain directory rockbox-3.0
* docs/VERSION file should exist and contain the 'official' release number

- lang files are not OK:
* LANG_ALBUMART is only available in english and italiano: if you change 'export LANGUAGE=francais' it will not compile
* the francais.lang file is wrong (patch included) and doesn't work correctly for some strings if loaded dynamically
This task depends upon

Closed by  Nils Wallménius (nls)
Wednesday, 08 October 2008, 19:31 GMT
Reason for closing:  Fixed
Additional comments about closing:  The source archive was fixed and the lang fixes in the patch was committed.
Comment by Marc Guay (Marc_Guay) - Friday, 26 September 2008, 11:27 GMT
The first problem, regarding the release page not displaying the new information, can be solved by hitting refresh on your browser - it's loading a cached version.
Comment by Nils Wallménius (nls) - Sunday, 28 September 2008, 05:03 GMT
The 7z archive appears to have been created from the trunk not the release branch. LANG_ALBUMART is not present in the release.
Support for setting LANGUAGE when building has been removed.
What is it that's wrong in the francais.lang? what happens when it's loaded dynamically and how does your patch fix it?
Comment by Nils Wallménius (nls) - Monday, 29 September 2008, 18:44 GMT
The source archive has been fixed.
Comment by Rafaël Carré (funman) - Wednesday, 08 October 2008, 19:13 GMT
I attach a modified patch to francais.lang only.

As discussed on IRC, "Œuvre" is a better translation for "Work" in the context of the ID3 grouping tag.
I also removed the modification of the translation of "Previous":
- "PrécédEnt" as an adjective is more intuitive than the verbal form "PrécédAnt"
Comment by Rafaël Carré (funman) - Wednesday, 08 October 2008, 19:18 GMT
here is a non empty patch