Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Plugins
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Soap - 2008-09-28
Last edited by RMenes379 - 2008-10-03

FS#9428 - Battery bench message is only correct for HW codec players.

When you attempt to load another plugin while battery bench is running a dialog pops up:

Batt.Bench is currently running.
Press OFF to cancel the test.
Anything else will resume.

“OFF” is only the correct key for HWcodec.

I know there is more than one way to fix this, perhaps one way smaller than the patch I offer, but I don’t know how to concatenate strings w/o including STRING.H (which I assume nobody wants me to do here.)

Closed by  RMenes379
2008-10-03 11:50
Reason for closing:  Accepted
Additional comments about closing:  

Committed, take 2.

String literals can be concatenated by simple putting them next to each other, for example printf(”hello " “world!\n”);
The patch looks fine to me otherwise.

Soap commented on 2008-09-29 19:08

Well, I can either keep it as it is now (with the new #define BATTERY_OFF_MSG for all targets), or the other thought I had was to change BATTERY_OFF_TXT to just the name of the button involved (instead of the string it is now) and replace both the current display of BATTERY_OFF_TXT to a concatenated string as well as replacing “Press OFF to cancel the test” with a concatenated string.

I don’t know which method is preferred.

Soap commented on 2008-10-01 22:28

Here is a “more elegant” version of the patch, one which uses no additional #define lines, but changes one of the existing ones.
Perhaps people will like this one better.

Committed, but temporarily pulled as it appears to break on the Player.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing