• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Music playback
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by CFP - 2008-10-02
Last edited by gotthardt - 2008-12-27

FS#9444 - Balance setting not working properly

It seems to me that the ‘balance’ setting is correlated to volume setting : the louder the music, the more important the volume difference between the earphones. Plus,, when the sound is of, but the balance is not set to 0, the music keeps playing.

Steps to reproduce :
Set the balance to +100%
Turn the to mute

Set the volume to a quite low value, and move from +100 to -100


Closed by  gotthardt
2008-12-27 21:05
Reason for closing:  Fixed

What target/player are you seeing this on?

CFP commented on 2008-10-04 05:47

On my Gigabeat F, running latest build.

CFP commented on 2008-10-04 05:53

It seems to me that on the sim the volume cannot go under 72, while on the target it goes down to 73, before being set to mute. Is this normal ?

I have a Gigabeat FX and I have confirmed this - I’ll take a look.
Thanks for reporting it.

I made a couple of minor changes and it seems to work.
I am going to chat on IRC to see if there are any ‘gotchas’ before submitting.

The problem is in sound.c
When balance is reduced below VOLUME_MIN it is set to VOLUME_MIN. It should be muted.
I removed the checks for this because the volume is clamped in the respective audio device drivers (ie wm8751.c)


I committed the fix. Tested only on Gigabeat F40.
Note: due to crosstalk, etc. program material can be heard on muted channels at high volumes. For example: put balance entirely on right channel, raise volume high and you can hear some sound on the left channel. Could be it is just my player.


Available keyboard shortcuts


Task Details

Task Editing