Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by wpyh - 2008-10-06
Last edited by pondlife - 2008-10-08

FS#9461 - Display current directory rather than "Files" for root directory

This patch changes the behaviour of the file browser if “Show Path” is set to “Current Directory Only”.

Old behaviour: For the root directory, show “Files”.
New behaviour: For the root directory, show “/”.

   display_dir_name.v1.diff (0.9 KiB)
Closed by  pondlife
2008-10-08 16:32
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

As requested by patch author.

alexwallis646 commented on 2008-10-06 17:54

So does this patch change the behaviour of the file browser so that it won’t show the player root any more? or can you set how the browser is to behave? in other words, is there an option so that you can either set it to show the player root or the current folder. i’m very glad you put this patch together, its something that’s anoyed me about the file browser for some time.

fml2 commented on 2008-10-07 18:38

Personally I like it as it is now. Just a slash would look like a random symbol or even a bug IMHO.

alexwallis646 commented on 2008-10-07 20:18

I think if i’ve understood the function of this patch right, that what it does is make the file browser put you in the last folder you were in when you switch the player off, rather than just sticking you back in the player root. am I right? or have i completely misunderstood the function of this patch. If I am right, I think there should be a setting to control if the file browser puts you in the last folder you were in or the root. as there will be people who like both settings.

fml2 commented on 2008-10-07 20:57

Alex, I think you have misunderstood what the patch does. The patch shows a slash instead of the word “Files” if you are in the root folder in the file browser and the option “Show File Path” is set to “Current directory only.” It doesn’t change anything in the RockBox behaviour.

What you are talking about (or something similar) is discussed in this forum thread: http://forums.rockbox.org/index.php?topic=10611.0

But the discussion is kind of stuck. I personally would like the feature.

pondlife commented on 2008-10-08 06:46

Personally, I prefer “Files” for “Current Directory Only” or “/” for “Full path”…

wpyh commented on 2008-10-08 16:00

Hi, uh… yeah, I forgot to answer the comments.

It seems that fml2 and pondlife has got it right – this patch just changes the “Files” string displayed when we are browsing the root directory to “/”. I personally think displaying “Files” instead of “/” would make it too-special-case-y.

pondlife commented on 2008-10-08 16:04

The reason for “Files” is that the title then displays the same as the parent menu item - i.e. making the browser feel integrated into the main menu.

wpyh commented on 2008-10-08 16:27

Ah, you’ve got a point there. Looking at it that way – yes, it feels more integrated into the menu. I’m taking back my patch.

Could someone please close this task?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing