Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#9461 : Display current directory rather than "Files" for root directory

Rockbox

Tasklist

FS#9461 - Display current directory rather than "Files" for root directory

Attached to Project: Rockbox
Opened by William Poetra Yoga Hadisoeseno (wpyh) - Monday, 06 October 2008, 14:55 GMT
Last edited by Steve Bavin (pondlife) - Wednesday, 08 October 2008, 16:32 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch changes the behaviour of the file browser if "Show Path" is set to "Current Directory Only".

Old behaviour: For the root directory, show "Files".
New behaviour: For the root directory, show "/".
   display_dir_name.v1.diff (0.9 KiB)
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 08 October 2008, 16:32 GMT
Reason for closing:  Rejected
Additional comments about closing:  As requested by patch author.
Comment by alex wallis (alexwallis646) - Monday, 06 October 2008, 17:54 GMT
So does this patch change the behaviour of the file browser so that it won't show the player root any more? or can you set how the browser is to behave? in other words, is there an option so that you can either set it to show the player root or the current folder. i'm very glad you put this patch together, its something that's anoyed me about the file browser for some time.
Comment by Alexander Levin (fml2) - Tuesday, 07 October 2008, 18:38 GMT
Personally I like it as it is now. Just a slash would look like a random symbol or even a bug IMHO.
Comment by alex wallis (alexwallis646) - Tuesday, 07 October 2008, 20:18 GMT
I think if i've understood the function of this patch right, that what it does is make the file browser put you in the last folder you were in when you switch the player off, rather than just sticking you back in the player root. am I right? or have i completely misunderstood the function of this patch. If I am right, I think there should be a setting to control if the file browser puts you in the last folder you were in or the root. as there will be people who like both settings.
Comment by Alexander Levin (fml2) - Tuesday, 07 October 2008, 20:57 GMT
Alex, I think you have misunderstood what the patch does. The patch shows a slash instead of the word "Files" if you are in the root folder in the file browser and the option "Show File Path" is set to "Current directory only." It doesn't change anything in the RockBox behaviour.

What you are talking about (or something similar) is discussed in this forum thread: http://forums.rockbox.org/index.php?topic=10611.0

But the discussion is kind of stuck. I personally would like the feature.
Comment by Steve Bavin (pondlife) - Wednesday, 08 October 2008, 06:46 GMT
Personally, I prefer "Files" for "Current Directory Only" or "/" for "Full path"...
Comment by William Poetra Yoga Hadisoeseno (wpyh) - Wednesday, 08 October 2008, 16:00 GMT
Hi, uh... yeah, I forgot to answer the comments.

It seems that fml2 and pondlife has got it right -- this patch just changes the "Files" string displayed when we are browsing the root directory to "/". I personally think displaying "Files" instead of "/" would make it too-special-case-y.
Comment by Steve Bavin (pondlife) - Wednesday, 08 October 2008, 16:04 GMT
The reason for "Files" is that the title then displays the same as the parent menu item - i.e. making the browser feel integrated into the main menu.
Comment by William Poetra Yoga Hadisoeseno (wpyh) - Wednesday, 08 October 2008, 16:27 GMT
Ah, you've got a point there. Looking at it that way -- yes, it feels more integrated into the menu. I'm taking back my patch.

Could someone please close this task?

Loading...