Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2008-10-11
Last edited by fml2 - 2010-10-11

FS#9475 - Make timeout parsing more flexible in wps_parser

The patch splits the parse_timeout function into a worker one and the functions used for a specific tag thus allowing to define context sensitive logic more locally. Also, the worker function doesn’t need to know where it is called from.

Closed by  fml2
2010-10-11 14:55
Reason for closing:  Rejected
Additional comments about closing:  

The patch is very probably obsolete by now; code has moved on.

I see what your doing, but im not sureits worth doing untill at least one or a few more tags want to use it

fml2 commented on 2008-10-12 09:40

I think that the clean code is always worth it. This way you won’t have to remember something that you know now but will forget in a couple of days.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing