Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jdgordon - 2008-11-04
Last edited by jdgordon - 2008-11-05

FS#9525 - change the UI to set the quickscreen items

This changes the UI to choose the quickscreen items to a context menu inside the setting changing screen.
If the setting is quickscreen-able the context menu will have "reset setting" and 3 options to set the setting on the QS. if its not then only the reset setting item will be displayed.

on non QS targets thee is no change (i.e the context menu button still resets the setting but there is no menu)

I'm not sure if the menu should be inside the option screen, or as a context menu on the actual setting item in the menus?

This menu could be used later if/when a "help" plugin is ever implemented.

This patch replaces the new LANG items. I'm not sure if this needs to bump the version (in which case we should remove the deprecated strings also) or leave it if this goes in quickly because not many people will be inconvenienced?

edit: forgot to mention that this bring the "actual size" value down by ~700 bytes on a e200

   quickscreen.1.diff (13.1 KiB)
Closed by  jdgordon
2008-11-05 09:31
Reason for closing:  Accepted
jdgordon commented on 2008-11-04 10:39

this version puts the context menu on the setting instead of inside the setting screen.

I'm not sure which version I prefer. This one will give a context menu to some menu items (and a select few will only have the item "reset setting"). the title will be "Context Menu" but could be changed to the settings name?

   quickscreen.2.diff (14.3 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing