FS#9525 - change the UI to set the quickscreen items

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 04 November 2008, 06:39 GMT
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 05 November 2008, 09:31 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This changes the UI to choose the quickscreen items to a context menu inside the setting changing screen.
If the setting is quickscreen-able the context menu will have "reset setting" and 3 options to set the setting on the QS. if its not then only the reset setting item will be displayed.

on non QS targets thee is no change (i.e the context menu button still resets the setting but there is no menu)

I'm not sure if the menu should be inside the option screen, or as a context menu on the actual setting item in the menus?

This menu could be used later if/when a "help" plugin is ever implemented.

This patch replaces the new LANG items. I'm not sure if this needs to bump the version (in which case we should remove the deprecated strings also) or leave it if this goes in quickly because not many people will be inconvenienced?

edit: forgot to mention that this bring the "actual size" value down by ~700 bytes on a e200
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 05 November 2008, 09:31 GMT
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Tuesday, 04 November 2008, 10:39 GMT
this version puts the context menu on the setting instead of inside the setting screen.

I'm not sure which version I prefer. This one will give a context menu to some menu items (and a select few will only have the item "reset setting"). the title will be "Context Menu" but could be changed to the settings name?