Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#9527 : irc reader broken for ff3

Rockbox

FS#9527 - irc reader broken for ff3

Attached to Project: Rockbox
Opened by Alexander Papst (DerPapst) - Tuesday, 04 November 2008, 17:26 GMT
Last edited by Björn Stenberg (zagor) - Wednesday, 05 November 2008, 11:48 GMT

Task Type	Patches
Category	User Interface
Status	Closed
Assigned To	No-one
Operating System	All players
Severity	Low
Priority	Normal
Reported Version	Daily build (which?)
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

This patch fixes a CSS issue introduced with the last irc reader update which makes the live log almost unreadable in FF3 at least.

Additionally it escapes 2 minuses into −− to avoid bricking the live log if someone posts --Delimeter or similar magic in the irc channel (see http://www.rockbox.org/irc/log-20081104).

Tested and works :)

This task depends upon

Closed by Björn Stenberg (zagor)
Wednesday, 05 November 2008, 11:48 GMT
Reason for closing: Accepted
Additional comments about closing: Delimiter regex accepted.

Javascript changes rejected. That span is definitely not a table row.

Comments (4)
Related Tasks (0/0)

Comment by Alexander Papst (DerPapst) - Tuesday, 04 November 2008, 17:27 GMT

Wait.. there was something to attach wasn't there?

irc_reader.diff (1.3 KiB)

Comment by Alexander Papst (DerPapst) - Tuesday, 04 November 2008, 18:48 GMT

Oops :-)
Forgot to change one line.

irc_reader.diff (1.6 KiB)

Comment by Peter D'Hoye (petur) - Wednesday, 05 November 2008, 10:45 GMT

irc reader works fine in minefield (ff3.1 beta2)

Comment by Rafaël Carré (funman) - Wednesday, 05 November 2008, 10:57 GMT

and fine in 3.0°.3 (although it didn't use to?)

ffox303.png (67.9 KiB)

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Loading...