Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Alexander Papst - 2008-11-04
Last edited by Björn Stenberg - 2008-11-05

FS#9527 - irc reader broken for ff3

This patch fixes a CSS issue introduced with the last irc reader update which makes the live log almost unreadable in FF3 at least.

Additionally it escapes 2 minuses into −− to avoid bricking the live log if someone posts –Delimeter or similar magic in the irc channel (see http://www.rockbox.org/irc/log-20081104).

Tested and works :)

Closed by  Björn Stenberg
2008-11-05 11:48
Reason for closing:  Accepted
Additional comments about closing:  

Delimiter regex accepted.

Javascript changes rejected. That span is definitely not a table row.

Alexander Papst commented on 2008-11-04 17:27

Wait.. there was something to attach wasn’t there?

   irc_reader.diff (1.3 KiB)
Alexander Papst commented on 2008-11-04 18:48

Oops :-) Forgot to change one line.

   irc_reader.diff (1.6 KiB)
Peter D'Hoye commented on 2008-11-05 10:45

irc reader works fine in minefield (ff3.1 beta2)

Rafaël Carré commented on 2008-11-05 10:57

and fine in 3.0°.3 (although it didn’t use to?)

   ffox303.png (67.9 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing