FS#9531 - Archos - Shuffle not operating correctly.

Attached to Project: Rockbox
Opened by Alun Thomas (tspoon) - Thursday, 06 November 2008, 21:44 GMT
Last edited by Boris Gjenero (dreamlayers) - Tuesday, 07 April 2009, 16:46 GMT
Task Type Bugs
Category Playlists
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Shuffle does not work after powering down then back up, it says shuffle is on, but playback is sequential. is you toggle shuffle to off, then shuffle re-starts (from position 1 in playlist), even though it says off. if you toggle back to on, shuffle continues.
This task depends upon

Closed by  Boris Gjenero (dreamlayers)
Tuesday, 07 April 2009, 16:46 GMT
Reason for closing:  Out of Date
Additional comments about closing:  Commit from r19723 was reverted in r20641. A different fix is needed. Discussion about this bug now takes place in FS#9822
Comment by Jonathan Gordon (jdgordon) - Sunday, 30 November 2008, 05:19 GMT
is this a problem still? what build are you using and (roughly) when was the build date of the build you upgraded from. I'm guessing a change a while ago to how shuffle is resumed was the problem, in which case it shouldnt be happening anymore
Comment by Alun Thomas (tspoon) - Sunday, 30 November 2008, 16:27 GMT
Yes, I have just flashed with the latest (November 30th 2008) and it still displays this behaviour. I will try with 3.0, because I suspect this problem has been introduced since then.
Comment by Alun Thomas (tspoon) - Sunday, 30 November 2008, 16:29 GMT
The build I was previously using was post 3.0, about several weeks later roughly. Before that I was running a daily build from about 2 months previous to 3.0
Comment by Alun Thomas (tspoon) - Monday, 01 December 2008, 19:24 GMT
I just tried 3.0.1 which does not display this exact behaviour. however it is still not as i expected. i.e. play a 13 song directory, shuffle off. activate shuffle. skip to next track. plays track 13 position is 2/13. toggle shuffle off. 13 continues playing but shows track 1/13, next track it plays is track 1 followed by 2,3,4 etc. I would have expected it to show 13/13 and then finish the directory, this is the traditional behaviour.
I cannot access 3.0 as it is not available on the archive page for archos recorder v1.
Comment by Alun Thomas (tspoon) - Monday, 01 December 2008, 19:26 GMT
p.s. repeat was 'off' in above example
Comment by Jonathan Gordon (jdgordon) - Thursday, 08 January 2009, 12:59 GMT
did a bit of investigating... my commits around r18560 broke this... testing pre that works and post doesnt...
I'm not sure why.. but this should be fixed soon... hopefully...
Comment by Boris Gjenero (dreamlayers) - Monday, 06 April 2009, 23:21 GMT
I don't see how fixes anything, and it causes a new problem. It should probably be reverted.

When one starts shuffled play of a directory with "Play Selected First" set to "Yes", the selected track is the first track in a playlist. After resuming, the playlist should be identical. With this patch, the playlist is rotated. (eg. some tracks at the beginning should be at the end) That's because this patch causes the second (<index>) parameter of the "Shuffle playlist" command to be ignored. Note "playlist->first_index = atoi(str2);" in PLAYLIST_COMMAND_SHUFFLE case in playlist_resume().