• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2008-11-16
Last edited by jdgordon - 2008-11-22

FS#9557 - Correctly interpret the number parameter of the %mv wps tag

The number parameter in the %mv tag (volume changing) should be interpreted as seconds. But it’s interpreted as 0.1 secs. I.e. 2.5 will wait 0.25 secs instead of 2.5. The patch fixes that.

Closed by  jdgordon
2008-11-22 10:31
Reason for closing:  Accepted
fml2 commented on 2008-11-16 12:37

Another try (moved private symbols from .h to .c).

fml2 commented on 2008-11-17 21:53

A comment for the reviewers: it might be better to store the timeout not in 0.1 sec units (as it’s done now) but directly in ticks (i.e. in 0.01 sec units). Then the interpreting code wouldn’t need to do any scaling. But in the WPS structure, the subline timeout is stored as an unsigned char. That would be too small for storing ticks, hence I left it in tenth of a second. I didn’t want to make the data structure bigger in size.


Available keyboard shortcuts


Task Details

Task Editing