Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Alex Bennee - 2008-11-21
Last edited by Björn Stenberg - 2008-11-24

FS#9567 - Add support for configurable root directory for Rockbox firmware

The Rockbox file browser has the ability to load new firmware by selecting an alternative rockbox.ipod. However this is rather pointless as the support files in “/.rockbox” will be for the old build.

This series of patches allow you to configure rockbox with an alternate directory:

../tools/configure –target=22 –ram=64 –type=N –rbdir=rockboxdev.alt

Which after building will give you a complete install zip file which extracts into “rockboxdev.alt”. Although this build will never be the primary build (the bootloader is hardwired for .rockbox) it does mean you can run a development build without having to break your existing working setup.

Closed by  Björn Stenberg
2008-11-24 22:16
Reason for closing:  Accepted
Admin
Björn Stenberg commented on 2008-11-21 10:21

Looks fine to me. But can you please upload a single patch done with “svn diff” in the rockbox root, instead of the five different files we have here?

Alex Bennee commented on 2008-11-21 10:56

Here is the patch in one big file from SVN diff.

I uploaded multiple patches more as an aid to reviewers so I could “show the working” and the comments for each change.

If people prefer reviewing monolithic patches I can just stick with a whole diff for each tracker entry or submit both a series and an “all” patch.
I don’t mind applying the patch to a local SVN to generate the diff but git-diff patches should easily apply with “patch -p1 < git-diff.patch”.
As you can probably tell I do all my work in a git-svn repo so I can do things in nice bi-sectable discreet steps.

Admin
Björn Stenberg commented on 2008-11-21 11:20

Generally we prefer single “monolithic” patches.

And yes, a git patch should probably work just as well.

Robert Keevil commented on 2008-11-21 13:44

Would it be worth at the same time fixing up the few locations in the source outside of the bootloader where “.rockbox” is still hardcoded?
e.g.:
firmware/include/dircache.h:31
firmware/common/unicode.c:21
firmware/export/font.h:53

Alex Bennee commented on 2008-11-21 16:00

I’ll have a look. I wasn’t sure which bits where the bootloader and which the actual firmware.

Alex Bennee commented on 2008-11-21 16:40

I think I have them all ignoring all the BOOTDIR stuff (for bootcode?) and changes to the manuals (not relevant for user builds?)

Alex Bennee commented on 2008-11-21 16:41

with the file this time.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing