• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mc2739 - 2008-11-22
Last edited by linuxstb - 2008-12-16

FS#9569 - fix for e200v2 lcd_update_rect

This patch corrects an issue with lcd_update_rect in lcd-e200v2.c

Also, an unnecessary setting for the button light is removed since this function is in backlight-e200v2-fuze.c

Closed by  linuxstb
2008-12-16 07:52
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as r19453

Do the same for fuze as well.

The OF seems to set that GPIO at LCD init though. My guess is now, that due to the inability to configure the button light in the OF, that the OF just turns on the button light always with the lcd and/or backlight.

Oops, forgot the lcd_update_rect part.

linuxstb should have a look at that before committing, as he wrote the fuze lcd driver which seems to have some similarities with the e200v2 one.


What "issue" is the use of lcd_framebuffer[x][y] fixing? It doesn't make sense to access the lcd framebuffer that way - it's defined to be [y][x].

I've just committed the GPIOD part of this patch (for both Fuze and e200v2) to SVN.

Dave, without this change, on display of the main menu, the display is shifted right when the status bar is on instead of being shifting down. This was the only change that I found that would display the menu properly.

Do not modify the CCU_IO register since we don't use GPIOD - same change as made in r19257 for Sansa Fuze

the above patch has been commited.

This patch corrects lcd_update_rect properly. Tested with credits.rock which uses the lcd_update_rect function.


Available keyboard shortcuts


Task Details

Task Editing