Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by kugel. - 2008-11-24
Last edited by zagor - 2008-11-24

FS#9575 - Preliminary button driver for Sansa Fuze

Simply copied button_int from button-e200v2.c.

I also updated the V2HardwareMapping wiki page accordingly.

Closed by  zagor
2008-11-24 20:51
Reason for closing:  Accepted

as said on irc, I prefer if the unneeded gpio*_dir are removed; since they won’t be used in something else than buttons (to check with the hardware mappings wiki)

gpio*_afsel need to be preserved since they are used in lcd.

Also I’m not familiar with the rockbox threads; could an interrupt happen while these registers are set to gpio (xpb and xpc as gpio), and switch the CPU to LCD code (which would need xpb and xpc as DBOP) ?

That can be done after commit imho in a seperate patch, which will not only affect fuze, but also e200 of course.

Also, I did some test and wasn’t quite successful.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing