Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by FranzD2 - 2008-11-29
Last edited by shotofadds - 2009-09-26

FS#9590 - Cowon D2 touchscreen driver registers wrong presses

Cowon D2 touchscreen driver registers wrong presses.

Closed by  shotofadds
2009-09-26 20:58
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Obsolete as of r22843

FranzD2 commented on 2008-11-29 21:23

This patch solves the problem, it introduces an error compensation mechanism when reading values from the touchscreen and a busy wait on the “data ready” flag of the corresponding ADC instead of just writing ADCSTART and reading the value immediately.
Thgis patch applies to firmware/target/arm/tcc780x/cowond2/button-cowond2.c .

   rockbox-cowond2-button-touchs... (6.1 KiB)
mcuelenaere commented on 2008-11-30 12:56

TABs aren’t compliant with the Rockbox guidelines ( http://svn.rockbox.org/viewvc.cgi/trunk/docs/CONTRIBUTING?view=markup ), you’ll need to replace them with 4 spaces.

FranzD2 commented on 2008-11-30 17:21

Replaced all tabs with 4 spaces, sorry :)

   rockbox-cowond2-button-touchs... (7 KiB)
FranzD2 commented on 2009-02-08 14:13

Ok, this patch include the calibration fix, hopefully that’s the last one :)

   altTouchScreen_mode_calibrati... (7.8 KiB)
Shad0w commented on 2009-05-12 11:40

I can’t apply this patch.
Why?

:~/rockbox$ patch -p0 < altTouchScreen_mode_calibration_fix.patch
patching file firmware/target/arm/tcc780x/cowond2/button-cowond2.c
Hunk #3 succeeded at 29 with fuzz 2 (offset -1 lines).
Hunk #4 succeeded at 36 (offset -18 lines).
Hunk #5 succeeded at 52 (offset -18 lines).
Hunk #6 succeeded at 68 (offset -18 lines).
Hunk #7 FAILED at 92.
1 out of 7 hunks FAILED – saving rejects to file firmware/target/arm/tcc780x/cowond2/button-cowond2.c.rej

P.S. SVN (revision 20916)

andrewthecoder commented on 2009-05-17 01:40

The patch fails because that file has changed too much since the patch was made.
Have a look: http://svn.rockbox.org/viewvc.cgi/trunk/firmware/target/arm/tcc780x/cowond2/button-cowond2.c?view=log

Judging by the date of Franz’s post above (8th February 2009), I suggest you try revision 18338 of that file.

Wait, by the looks of revision 20527, rob committed part of this patch to SVN already, so this patch is obsolete as far as I understand.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing