FS#9591 - Philips GoGear HDD16x0/HDD63x0 patches for power, sound, buttons, lcd

Attached to Project: Rockbox
Opened by Anton Veretenenko (lifeless) - Sunday, 30 November 2008, 00:18 GMT
Last edited by Szymon Dziok (b0hoon) - Monday, 25 October 2010, 12:02 GMT
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Target: PHILIPS_HDD1630
SVN revision: 19036

Here is diff files.

Rockbox boot freeze fixed.
Charger detection, usb detection, lcd backlight on/off, power on/off.
LCD format fixed.
Sound works now.
Button buzzer like in OF (not in headphones).
Model name changed, if it's not ok, just don't use.

button-target.h-testing.without.touchpad.diff is for testing Rockbox without touchpad. Up, down, left, right buttons remapped to side buttons.

There are sound distortions on hight volume, but OF sound is better, dunno why, investigating.
This task depends upon

Closed by  Szymon Dziok (b0hoon)
Monday, 25 October 2010, 12:02 GMT
Reason for closing:  Out of Date
Additional comments about closing:  These patches are already in SVN, some of them in different version. Outdated.
Comment by Mark Arigo (lowlight) - Sunday, 30 November 2008, 01:49 GMT
Nice work. I haven't had much time for this since I did the initial hdd1630 commit. I'll review it this coming week.
Comment by Anton Veretenenko (lifeless) - Wednesday, 10 December 2008, 19:19 GMT
Here is another patch for lcd contrast (OF name it as brightness). I have tried to use HAVE_BACKLIGHT_BRIGHTNESS, but after compilation, settings menu still show it as "contrast" and there is glitches in menu (e.g. no debug menu, codepage menu have caption of actual codepage name (latin-...), runtime menu does not have caption, no manage configurations menu) and this looks like a bug.
So I have changed it to use HAVE_LCD_CONTRAST.
Comment by Mark Arigo (lowlight) - Friday, 12 December 2008, 05:21 GMT
I committed your first patches.
To my ears, the button click doesn't sound as loud it does with the OF.
I'll take a look at your brightness patch (I saw that in the OF as well).
I will try to make the touchpad next.
Let's keep this task open for related patches.
Comment by Anton Veretenenko (lifeless) - Thursday, 18 December 2008, 18:52 GMT
For RTC:

#define CONFIG_RTC RTC_E8564
Comment by Anton Veretenenko (lifeless) - Thursday, 18 December 2008, 18:56 GMT
Oh, and I got why menus messed up. I have updating only rockbox binary and not full set of files.
Comment by Mark Arigo (lowlight) - Friday, 19 December 2008, 02:57 GMT
Good to know the RTC works. I found the RTC code in the OF disassembly, and did notice a similarity to E8564, but never got around to testing the code as is.
I also found the FM code which also shouldn't take to much to enable.