• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lifeless - 2008-11-30
Last edited by b0hoon - 2010-10-25

FS#9591 - Philips GoGear HDD16x0/HDD63x0 patches for power, sound, buttons, lcd

Target: PHILIPS_HDD1630
SVN revision: 19036

Here is diff files.

Rockbox boot freeze fixed.
Charger detection, usb detection, lcd backlight on/off, power on/off.
LCD format fixed.
Sound works now.
Button buzzer like in OF (not in headphones).
Model name changed, if it’s not ok, just don’t use.

button-target.h-testing.without.touchpad.diff is for testing Rockbox without touchpad. Up, down, left, right buttons remapped to side buttons.

There are sound distortions on hight volume, but OF sound is better, dunno why, investigating.

Closed by  b0hoon
2010-10-25 12:02
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

These patches are already in SVN, some of them in different version. Outdated.

Nice work. I haven’t had much time for this since I did the initial hdd1630 commit. I’ll review it this coming week.

Here is another patch for lcd contrast (OF name it as brightness). I have tried to use HAVE_BACKLIGHT_BRIGHTNESS, but after compilation, settings menu still show it as “contrast” and there is glitches in menu (e.g. no debug menu, codepage menu have caption of actual codepage name (latin-…), runtime menu does not have caption, no manage configurations menu) and this looks like a bug.
So I have changed it to use HAVE_LCD_CONTRAST.

I committed your first patches.
To my ears, the button click doesn’t sound as loud it does with the OF.
I’ll take a look at your brightness patch (I saw that in the OF as well).
I will try to make the touchpad next.
Let’s keep this task open for related patches.

For RTC:

#define CONFIG_RTC RTC_E8564

Oh, and I got why menus messed up. I have updating only rockbox binary and not full set of files.

Good to know the RTC works. I found the RTC code in the OF disassembly, and did notice a similarity to E8564, but never got around to testing the code as is.
I also found the FM code which also shouldn’t take to much to enable.


Available keyboard shortcuts


Task Details

Task Editing