Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Frederick Full - 2008-12-09
Last edited by MichaelGiacomelli - 2009-01-08

FS#9617 - Keymaps for Plugins fuze

Well the plugins compile for me in the Simulator.

Hope this helps

Closed by  MichaelGiacomelli
2009-01-08 20:34
Reason for closing:  Accepted
Robert Menes commented on 2008-12-09 17:27

The keymaps look very good. If one of the Fuze developers can try it out on the real hardware, we’ll see about having this committed.

Frederick Full commented on 2008-12-09 17:49

Well buttons aren`t working on the fuze so its not possible to try on a real fuze.

Frederick Full commented on 2008-12-09 21:43

Just some cleaning

Frederick Full commented on 2008-12-10 18:26

That should be all of them now

Rafaël Carré commented on 2008-12-10 20:53

hello,

i noticed that some keymaps are the same than C200, any reason you wouldn’t rather use the e200 (which has a scrollwheel like the fuze, unlike the C200)?

i noticed also some lines like:
+#if CONFIG_KEYPAD != SANSA_E200_PAD | SANSA_FUZE_PAD

I’m not sure if simple ‘|’ has a meaning for C preprocessor

It rather should be like:
+#if CONFIG_KEYPAD != SANSA_E200_PAD && CONFIG_KEYPAD != SANSA_FUZE_PAD

Frederick Full commented on 2008-12-11 13:36

some plugins don`t use the schrollwheel on the e200 too so its the same keymap for c200, clip, fuze and the e200.

#if (CONFIG_KEYPAD != SANSA_E200_PAD) || (CONFIG_KEYPAD !=SANSA_FUZE_PAD)

I think it should work like this. In your way both SANSA_FUZE_PAD and SANSA_E200_PAD need to be false? but if one of them is true it would still compile without that code.

Rafaël Carré commented on 2008-12-11 13:43

No, it won’t work, *_PAD are always defined to different (incremental) values

Your if is always true:

if CONFIG_KEYPAD == SANSA_E200_PAD the first part is false, but the 2nd is true (SANSA_E200_PAD != SANSA_FUZE_PAD) and so the whole if is true.

Frederick Full commented on 2008-12-11 19:13

okay your right my bad.

Hier is the new patch.

Rafaël Carré commented on 2008-12-11 21:21

Looks ok to me.

Did you try all the plugins by the way ? Some can look bad if they use bitmaps (I dont know if another target exists with the same screen size)

If some bitmaps need to be procuced, this can be done later and this patch should be committed what ever (bug someone to commit it).

thanks you !

Frederick Full commented on 2008-12-13 12:53

I´ll have some more time next week. Maybe we have buttons until then. Working on the real device would give a better feeling I`ll have a look on the bitmaps and buttons then.

Frederick Full commented on 2008-12-22 12:47

Here is a patch for the current svn. You have to change tools/configure by yourself I don`t know if I should change that file.

I didn`t try all plugins on real hardware but I´ll do that now.

Eric Shattow commented on 2008-12-22 18:57

Tried above patch (2) on Sansa Fuze target.

Build Errors:

- No keymap for mandelbrot plugin (Typo: rename dupe’d E200 keymap chunk to FUZE)

Keymap Errors:

- Bubbles keymap is wrong (missed a chunk to update)

Corrected patch attached.

Thomas Martitz commented on 2009-01-04 22:50

Here’s an updated version.

I added some FIXMEs here and there, which I think should be fixed in other patches, and I have plans to do it myself soon, but I won’t stop anyone else from beating me.

Thomas Martitz commented on 2009-01-04 23:07

fix warnings in jewels.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing