Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by kugel. - 2008-12-11
Last edited by linuxstb - 2008-12-16

FS#9623 - Fuze lcd driver fixes

a) remove lcd_delay, doesn’t seem to be needed (and I didn’t find any such function in the 1.01.15 OF version)
b) add a lcd_write_cmd which I found in the OF
c) some fixes to lcd_update_rect
d) only execute lcd_enable if really needed

Closed by  linuxstb
2008-12-16 07:55
Reason for closing:  Accepted
Additional comments about closing:  

Committed as r19452.

It looks ok to me, I’ll just wait for your confirmation

Ok, some small cleanup to lcd_init

some more stuff:

add a mutex, so that lcd transfers are undisturbed (and they will be without by buttons)
add a small delay in lcd_enable to avoid irritating/epilepsy causing flash when called (i.e. at backlight on).

Someone volunteers to commit?

remove lcd_mutex alltogether, it’s apprently not needed.

Commited. I’ll leave this open in case you make further changes.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing