• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Music playback
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by dreamlayers - 2008-12-14
Last edited by bertrik - 2009-01-31

FS#9638 - temp_cue is unused and wasting memory

It seems that in the past there was an attempt to load up to two cue sheets into memory, using curr_cue for the current track, and temp_cue for an upcoming track. Currently temp_cue is allocated and never loaded with data, wasting 70k. In gwps-common.c, the current filename is compared with uninitialized memory in temp_cue, which probably doesn’t cause problems but seems like a bad idea.

In this patch I’ve removed code relating to temp_cue.

Closed by  bertrik
2009-01-31 19:42
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as svn r19890


Available keyboard shortcuts


Task Details

Task Editing