Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasher - 2008-12-14
Last edited by jdgordon - 2010-08-15

FS#9640 - WPS comments "eat" line-endings

Comments in WPS files act very strangely if they’re not on a line of their own. The following (and attached) wps demonstrates this:

———-Start———-
Artist: %ia
Title: %it
foo
bar
Artist: %ia# Comment
Title: %it# Comment
———–End———–

Expected output:
———-Start———-
Artist: Dire Straits
Title: Walk Of Life
foo
bar
Artist: Dire Straits
Title: Walk Of Life
———–End———–

Actual output:
———-Start———-
Artist: Dire Straits
Title: Walk Of Life
foo
barArtist: Dire StraitsTitle: Walk Of Life
———–End———–

It seems to me that comment-characters should only “eat” line-endings if they’re at the beginning of a line?

This behaviour was introduced in r13140 (http://svn.rockbox.org/viewvc.cgi?view=rev&revision=13140), seemingly on purpose, but I don’t think “inline” comments were considered - that’s why I’m adding this as a bug.

As a note, at least one WPS in SVN uses this behaviour to break a long line, so if it’s fixed, that WPS should be modified as well.

   test.wps (0.1 KiB)
Closed by  jdgordon
2010-08-15 14:22
Reason for closing:  Wont Fix
Additional comments about closing:  

it seems that this behaviour is wanted. feel free to reopen and bring it up on the ml or irc if you want.

re-reading that forum thread confused me… did we actually come to a consensus at all? or should we close this because its not going to be fixed?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing