• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lazka - 2008-12-14
Last edited by mcuelenaere - 2009-01-29

FS#9643 - some themes.rockbox changes..

- display the targets in a table like on the other pages
- make rewrite rules etc. better to have better fall back than 404 on wrong urls
- add a upload link

Closed by  mcuelenaere
2009-01-29 21:57
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Thank you, parts of this are committed now.

lazka commented on 2008-12-17 19:14

Ok, ignore the patch.

I'm trying to rewrite the whole themes.rockbox site.
My php skills are a bit rusty.. so it will take a week or two.

Post here if you have any suggestions.

lazka commented on 2008-12-19 12:45

Here is a first shot. (copy to localhost root)

Read the README.
Admin panel isn't very nice (doesn't refresh) but more powerful.
I will continue if I get some feedback.

I just took a short look at this.

A few remarks:
- Theme site itself looks nice. But i dont think the bug-report link under the Themes is good here. We probably dont want Bugreports about user-themes in the tracker.

Perhaps it would be better to give to user a way to mark a theme as bad, which then can be inspected in the Admin panel.

- Admin-panel: I think this needs much more work to get it useable. It needes refreshes when you changes something. It should show the Theme when you click on the name and more. But it looks like a good start.

- I think one of the important things for this theme site is the automated checking when you upload a theme (maybe also rechecking in the admin interface). This should check all possible things (take a look at the upload/tools script in svn) and should also use checkwps to check the actual wps syntacs.

lets hope you continue you work, and we get a useable theme site fast :-)

lazka commented on 2009-01-14 23:36

New location:

Lots of exams ahead, so, not much time.

1) Started
2) It gets the job done for now… the only good solution I see is using "ajax" and that's not worth the effort.
3) Noted

Thanks for your review Dominik.


not sure if I should add it here, but I did an update of Maurus Cuelenare's original theme site code.It works now for me for uploading and accepting themes. Some of the changes I made:
- added some more text in the index.php and put it in an additional file intro.php
- made links work in intro.php and added new links included for upload
- added new model handling in ini.php (model class)
- added some more automatic setup in ini.php
- made upload.php more generic

  • support different unzip versions (with different output)
  • support more zip mimetypes, browser can return both application/zip and application/x-zip-compressed.
  • make filenames filesystem safe (instead of using html entities).

It can now be used to display and add themes.

What I would like to do:

  1. use a layout for displaying themes more like
  2. add support for sorting themes: alphabetically/popular/recently added/…
  3. add support for reporting problems (i.e. copyright infringment).
  4. add support in admin.php for removing accepted themes .
  5. make admin.php look a bit nicer.


Available keyboard shortcuts


Task Details

Task Editing