Notice: A non well formed numeric value encountered in /sites/ on line 96 Notice: A non well formed numeric value encountered in /sites/ on line 96 Notice: A non well formed numeric value encountered in /sites/ on line 96 Deprecated: Function create_function() is deprecated in /sites/ on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/ on line 845 Deprecated: Function create_function() is deprecated in /sites/ on line 111 FS#9643 : some themes.rockbox changes..



FS#9643 - some themes.rockbox changes..

Attached to Project: Rockbox
Opened by Christoph Reiter (lazka) - Sunday, 14 December 2008, 23:31 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Thursday, 29 January 2009, 21:57 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


- display the targets in a table like on the other pages
- make rewrite rules etc. better to have better fall back than 404 on wrong urls
- add a upload link
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Thursday, 29 January 2009, 21:57 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thank you, parts of this are committed now.
Comment by Christoph Reiter (lazka) - Wednesday, 17 December 2008, 19:14 GMT
Ok, ignore the patch.

I'm trying to rewrite the whole themes.rockbox site.
My php skills are a bit rusty.. so it will take a week or two.

Post here if you have any suggestions.
Comment by Christoph Reiter (lazka) - Friday, 19 December 2008, 12:45 GMT
Here is a first shot. (copy to localhost root)

Read the README.
Admin panel isn't very nice (doesn't refresh) but more powerful.
I will continue if I get some feedback.
Comment by Dominik Wenger (Domonoky) - Friday, 09 January 2009, 23:22 GMT
I just took a short look at this.

A few remarks:
- Theme site itself looks nice. But i dont think the bug-report link under the Themes is good here. We probably dont want Bugreports about user-themes in the tracker.
Perhaps it would be better to give to user a way to mark a theme as bad, which then can be inspected in the Admin panel.

- Admin-panel: I think this needs much more work to get it useable. It needes refreshes when you changes something. It should show the Theme when you click on the name and more. But it looks like a good start.

- I think one of the important things for this theme site is the automated checking when you upload a theme (maybe also rechecking in the admin interface). This should check all possible things (take a look at the upload/tools script in svn) and should also use checkwps to check the actual wps syntacs.

lets hope you continue you work, and we get a useable theme site fast :-)
Comment by Christoph Reiter (lazka) - Wednesday, 14 January 2009, 23:36 GMT
New location:

Lots of exams ahead, so, not much time.

1) Started
2) It gets the job done for now... the only good solution I see is using "ajax" and that's not worth the effort.
3) Noted

Thanks for your review Dominik.
Comment by Rob Schmersel (rosco_pc) - Friday, 23 January 2009, 12:15 GMT

not sure if I should add it here, but I did an update of Maurus Cuelenare's original theme site code.It works now for me for uploading and accepting themes. Some of the changes I made:
- added some more text in the index.php and put it in an additional file intro.php
- made links work in intro.php and added new links included for upload
- added new model handling in ini.php (model class)
- added some more automatic setup in ini.php
- made upload.php more generic
* support different unzip versions (with different output)
* support more zip mimetypes, browser can return both application/zip and application/x-zip-compressed.
* make filenames filesystem safe (instead of using html entities).

It can now be used to display and add themes.

What I would like to do:
- use a layout for displaying themes more like
- add support for sorting themes: alphabetically/popular/recently added/...
- add support for reporting problems (i.e. copyright infringment).
- add support in admin.php for removing accepted themes .
- make admin.php look a bit nicer.