Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To
    rasher
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lucent - 2008-12-15
Last edited by rasher - 2009-01-08

FS#9647 - Enhance tools/rockboxdev.sh to use environment variables for prefix, download, and build directories

Uses if available:
RBDEV_PREFIX
RBDEV_DOWNLOAD
RBDEV_BUILD

Modifies language a bit to say that user should set these instead of editing rockboxdev.sh

Closed by  rasher
2009-01-08 20:02
Reason for closing:  Accepted
Additional comments about closing:  

Committed in revision 19725, thank you.

Is this fine for committing during the freeze? If so, I’ll add it in a heartbeat. It’s pretty obviously a good idea.

Just because we’re already at rockboxdev.sh. I haven’t looked so I just ask: Does it use predefined make default options like -j if the user has set it in his environment? (I remember that issue came up in -community recently).

Project Manager

Perhaps RBDEV_MAKEOPT would be suitable for that… What “predefined make default options” are you referring to?

Options like (and this one inparticular ;) ) “-j #”

make has some switches (see make –help), some of which might be enabled in one’s environment, so that they’re used at every make by default.

Project Manager

in what way are they “enabled in one’s environment” ?

Someone mentioned it in #rockbox-community. The sad thing is that I have forgotten what he said :( But rasher was there too, he might remember, as he searched a way to let make automatically use -j instead of needing to hack rockboxdev.sh

I believe it’s MAKEOPTS, which you can set to whichever default options you want make to be invoked with. I don’t think rockboxdev.sh needs to handle this. It should Just Work[tm].

Nope, it’s MAKEFLAGS.

make obeys MAKEFLAGS environment variable.

I.e. user may try: RB_PREFIX=/opt/rockboxdev ./rockboxdev.sh

…which is good and will work, but trying: MAKEFLAGS=”-j” ./rockboxdev.sh

…may or may not work. It is not our responsibility. The user should be prepared with: export MAKEFLAGS=”-j”

Patch stands as-is, any sponsor willing to commit?

Still not sure if this is fine to commit during the freeze?

I’ll commit this when I get the time.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing