Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2008-12-17
Last edited by jdgordon - 2009-12-21

FS#9660 - Database selections trigger the dynamic playlist warning

Recipe:
1) Enable the “Warn when erasing dynamic playlist” option.
2) Play an album from the database.
3) Attempt to play a second album from the database.

Expected behaviour: No warning, as no manual playlist manipulation has taken place.
Actual behaviour: The warning is triggered.

Revision: r19463.

Closed by  jdgordon
2009-12-21 05:44
Reason for closing:  Fixed
Additional comments about closing:  

ignore that last comment…. wasnt too bad of a hack.. in r24089.

Besides of this bug, we should consider whether “dynamic” is confusing/missleading.

I’d understand this under dynamic playlist: The playlist that’s created when you start playing music by selecting a track. If you selected a playlist to start music, that’d not be dynamic.

If I understand correctly, the warning should be used to prevent the loss of unsaved playlist editing. If you’re using a saved playlist (i.e. an m3u), then the edits could be saved (I don’t know if we do this or not!). For a dynamic playlist, i.e. any on-the-fly selection then there’s no obvious place to save the changes.

However, if you’ve not performed any edits, this warning should not be needed. Unfortuanately the database sets up a playlist by using the same playlist API that manual insertions do, so from the point of view of the playlist code, edits are taking place.

No real surprise.. this is linked with the other database/playlist creation bugs where the db adds each track in the result instead of doing a single insert call. I dont tihnk there is a simple fix for this.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing