Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by kugel. - 2008-12-17
Last edited by Marc_Guay - 2008-12-30

FS#9661 - Quickscreen: Don't let the up button do anything

As per IRC talk, here’s a patch that makes the up button don’t do anything in the quickscreen.

The fact that the button changes the bottom item as well is unexpected (the quickscreen as is doesn’t indicate at all that the up button is mapped) and is likely to lead to changed settings by accident.

IMHO this should get into the release for the reasons mentioned.

This patch doesn’t touch the keymap files, as it doesn’t harm if they still define a ACTION_QS_DOWNINV button. I think cleanup those up should be done after the release, just to be safe.
Or just keep those, so that if a 4th item is going to happen it’s easier and faster (i.e. by search-and-replace) to define the button for the top item. You decide.

Doesn’t change anything for Recorder as it seems to be required for those.

Closed by  Marc_Guay
2008-12-30 20:40
Reason for closing:  Rejected
Additional comments about closing:  

See  FS#9706 

I really like the possibility to go “up” in the “down” item on my h100 and would hate to loose it. IMO it would be better to indicate that the bottom entry can also get changed that way.

Well, looks you’re one of the very few thinking this way.

But even if we did it like you propose (it would be a possible fix too of course), we would lose the possibility for a 4th item, and JdGordon said he’s at least planning on a 4th item (and that he definitely doesn’t want the top part to be blocked).

Ok, do it a little cleaner

Admin
fg commented on 2008-12-23 20:11

This applies and builds for all 3.1 release targets. I tested it on some of them, and saw no problems

Thanks! Sounds promising :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing