Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Thomas Martitz - 2008-12-18
Last edited by MichaelGiacomelli - 2009-01-18

FS#9663 - Sansa e200v2/Fuze: "nearly" fix buttonlight, enable backlight sw fading

This patch enables backlight sw fading for both mentioned targets. Looks nice on the Fuze.

It’s also supposed to fix buttonlight. It generally works, but it needs more work.
It’s quite unreliable!
It generally works if you press a button shortly after the very first buttonlight flash while booting, and it starts working if you do filesystem access. There may be other conditions.
It generally doesn’t work if you boot normally, until something mentioned above happens.

I just want to add: buttonlight ain’t trivial from what I’ve seen. Simply setting the pin is broken as soon as you add a MicroSD, since the MicroSD is blocking the GPIOD port. You basically cannot change xpd_func_sel to GPIO as long as you’re using the MicroSD. And the buttonlight doesn’t keep on just by setting the pin if you change to xpd.

What I did is what I found in the disassembly. It sets the Rod control register. It seems to work a bit, even though I have no idea what it actually is.

Enough talk, here’s the patch

Closed by  MichaelGiacomelli
2009-01-18 18:50
Reason for closing:  Accepted
Additional comments about closing:  

Accepted in r19791 and r10792.

Michael Chicoine commented on 2008-12-18 12:57

You forgot the backlight-target.h changes for e200v2

Thomas Martitz commented on 2009-01-16 23:14

Update for the buttonlight, works good. It turns off for a split second at inserting a microsd, but I don't think it's a major issue (I'd even say it's a nice visual feedback on inserting the card).

Thomas Martitz commented on 2009-01-16 23:51

Here's an update on backlight fading. The huge #if in backlight.c could actually reduced to HAVE_AS3514.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing