Rockbox

Tasklist

FS#9674 - Adds preliminary support for newer onda vx747+ (with camera).

Attached to Project: Rockbox
Opened by Olivier Barbut (oliv) - Friday, 19 December 2008, 03:14 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Friday, 19 December 2008, 11:33 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch adds config entry for the newer onda vx747+.
I found out that its buttons GPIO config was different from the vx747 one, and I could easily find out the correct one which is also implemented here. This is the only difference from the stock vx747 one.
The lcd and the touchscreen are working, so far so good :)

This is against current rockbox r19478
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Friday, 19 December 2008, 11:33 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Maurus Cuelenaere (mcuelenaere) - Friday, 19 December 2008, 10:29 GMT
As most of the onda_vx747p/* stuff is almost a copy of onda_vx747/* I prefer to use #ifdef's instead of adding a new file; that way there's less code redundancy (wrt sadc-onda_vx747p.c).

It also seems like you forgot to 'svn add' some files, like backlight-onda_vx747p.c and lcd-onda_vx747p.c
Could you make a new patch which includes these files?
Comment by Maurus Cuelenaere (mcuelenaere) - Friday, 19 December 2008, 11:33 GMT
I reworked your patch and committed it, so forget my last comment :)

Loading...