Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by oliv - 2008-12-19
Last edited by mcuelenaere - 2008-12-19

FS#9674 - Adds preliminary support for newer onda vx747+ (with camera).

This patch adds config entry for the newer onda vx747+.
I found out that its buttons GPIO config was different from the vx747 one, and I could easily find out the correct one which is also implemented here. This is the only difference from the stock vx747 one.
The lcd and the touchscreen are working, so far so good :)

This is against current rockbox r19478

Closed by  mcuelenaere
2008-12-19 11:33
Reason for closing:  Accepted
Additional comments about closing:  

Thanks!

As most of the onda_vx747p/* stuff is almost a copy of onda_vx747/* I prefer to use #ifdef’s instead of adding a new file; that way there’s less code redundancy (wrt sadc-onda_vx747p.c).

It also seems like you forgot to ‘svn add’ some files, like backlight-onda_vx747p.c and lcd-onda_vx747p.c
Could you make a new patch which includes these files?

I reworked your patch and committed it, so forget my last comment :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing