Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jaykay - 2008-12-19
Last edited by jdgordon - 2008-12-21

FS#9680 - empty .cfg file takes time to load

when i create a empty .cfg file in the themes-folder and select it with browse thems, the screen jitters(?) very short, then it says “loading…” for approx. 1 sec, then “loaded settings”…

but actally there is nothing to load, so why does it use so “much” time? the “loading….”-message should be not visible because the “settings loaded”-screen appears.

i know its not a real bug, but there could be something improved. maybe there are things checked which dont need to be checked, maybe all related settings are overwritten with the same settings or whatever. i dont know.

Closed by  jdgordon
2008-12-21 13:15
Reason for closing:  Wont Fix
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

patch is in the comments if this annoys you too much

Jaykay commented on 2008-12-19 18:11

i forgot: sansa e280 + r19396.

jdgordon commented on 2008-12-21 10:31

if it really annoys you, this patch will fix it. but I dont know if its worth putting in because how often would an empty .cfg be loaded?

   changes.patch (0.9 KiB)
Jaykay commented on 2008-12-21 12:30

ok, now empty .cfg files or .cfg files with nonsense need approx 1/10 sec :)

but if you create a .cfg file with a single line in it, i.e. background color: 000000, it needs again the full 2s to jitter, show “loading….” and “settings loaded”….

but i admit its not a real bug. if nobody thinks it makes sense to fix the non-existent bug, it can be closed.

jdgordon commented on 2008-12-21 12:35

there is no way to make it shorter… either we apply all the settings or we dont, so even a cfg with one line will still need to apply all settings

Jaykay commented on 2008-12-21 12:42

rockbox could overwrite only the new settings….. but i think the result is not worth the work (…??, you know what i mean) so this can be closed.

jdgordon commented on 2008-12-21 13:15

no, the setting loading and setting applying are done separately, and because of the way settings get applied this isnt possible.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing